Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convertDeprecatedApprovedClasspathEntriesThread should be transient #538

Merged
merged 1 commit into from
Nov 27, 2023
Merged

convertDeprecatedApprovedClasspathEntriesThread should be transient #538

merged 1 commit into from
Nov 27, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 13, 2023

#468 was incorrect; we would never want to try to serialize this Thread in scriptApproval.xml! Also best to null it out when complete.

@jglick jglick requested a review from a team as a code owner November 13, 2023 19:01
@jglick jglick added the bug label Nov 13, 2023
MarkEWaite
MarkEWaite approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@jglick jglick merged commit 67ca3d5 into jenkinsci:master Nov 27, 2023
14 checks passed
@jglick jglick deleted the convertDeprecatedApprovedClasspathEntriesThread branch November 27, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @MarkEWaite