-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward compatibility with core-8418 #522
Conversation
try { | ||
page.getAnchorByText(displayName).click(); | ||
} catch (ElementNotFoundException enf) { | ||
HtmlForm config = page.getFormByName("config"); | ||
r.getButtonByCaption(config, displayName).click(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback as in jenkinsci/text-finder-plugin#191 (review) about if/else vs try/catch
jenkinsci/jenkins#8418 will ship on Tuesday in 2.422, so this PR needs to be merged/released prior to that to avoid a new test failure in BOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and already labeled "developer" so that it will result in a new release when it is merged.
jenkinsci/jenkins#8418
Testing done
Submitter checklist