Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken icon on modern Jenkins versions #384

Conversation

NotMyFault
Copy link
Member

Fixes JENKINS-67771

Probably best to merge it after #373, because this change either requires 2.319.x or newer.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault
Copy link
Member Author

Heyo @car-roll,

now that you have have merged #373, do you mind taking a look at this PR too? The requirements are now met.
Thanks in advance :)

@car-roll car-roll added the bug label Feb 23, 2022
@car-roll car-roll merged commit f967fbe into jenkinsci:master Feb 23, 2022
@NotMyFault NotMyFault deleted the fix/master/fix-icon-on-modern-jenkins-version branch February 23, 2022 23:02
@NotMyFault
Copy link
Member Author

Could you try to trigger the release workflow again please? GitHub actions had an issue with drafts yesterday.
See https://groups.google.com/g/jenkinsci-dev/c/110lPg1O2u0 for reference.

@car-roll
Copy link
Contributor

car-roll commented Feb 26, 2022

@NotMyFault
Copy link
Member Author

@car-roll
Copy link
Contributor

yeah, looks okay now. I bunch of dependabot actions went through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants