Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60682] Improve scriptApproval ux #282

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jsoref
Copy link

@jsoref jsoref commented Jan 7, 2020

The main items are:

  • Wrap things in <p> so that they don't flow to the right of a label (:).
  • Offer None text of sorts instead of nothing...
  • Add extra headings and anchors

JENKINS-60682

@jsoref jsoref changed the title Improve scriptApproval ux [JENKINS-60682] Improve scriptApproval ux Jan 8, 2020
@jeffret-b
Copy link

@jsoref, I've been independently looking into some improvements for this page. It's still in the discussion stage, trying to figure out what makes sense. You've got some good ideas here. I'm working on pulling together some proposals and seeing where we can make some gains with limited efforts. I'll share what I come up with as soon as I can.

@Wadeck
Copy link
Contributor

Wadeck commented May 25, 2020

FYI the effort discussed by @jeffret-b led to #300

@DuMaM
Copy link

DuMaM commented Sep 18, 2022

I think those changes was approved or they where fixed with recent ui changes
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants