Document that a system property is required for ADFS #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottsfired
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
SANCTUARIO-482 for additional context.
I also suspect JENKINS-63703 is related, but not sure.
The Problem that @Vlatombe is talking about is related to the request to the ADFS (Jenkins->ADFS), JENKINS-63703 is related to the SAMLResponse signature, I am not sure is the same Jenkins accepts linebreaks in the signature. |
|
@Vlatombe I guess you have tested it, isn't it? Do you have the error in the ADFS side to add it to the troubleshooting guide? |
kuisathaverat
approved these changes
Dec 6, 2020
|
Sure, this was based on a customer issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like #89 has changed some behaviour w.r.t Base64 encoding, and ADFS doesn't like seeing line breaks and complains.
/cc @schottsfired
Submitter checklist