Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling unnecessary libraries #309

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Feb 1, 2023

Removes bcprov-jdk18on-1.71.jar and commons-lang3-3.11.jar from the WEB-INF/lib directory of the HPI file in favor of the corresponding library plugins. This is the preferred mechanism for dynamic linking in the Jenkins plugin ecosystem. CC @kuisathaverat

@@ -89,6 +89,10 @@ under the License.
</pluginRepositories>

<dependencies>
<dependency>
Copy link

@kuisathaverat kuisathaverat Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the dependency here and exclude from apache-httpcomponents-client-4-api that already have the dependency? Why not add the commons-lang3-api at apache-httpcomponents-client-4-api?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why […] exclude from apache-httpcomponents-client-4-api

I think you have misread the diff because the exclusion is from pac4j-saml, not from apache-httpcomponents-client-4-api.

@kuisathaverat kuisathaverat merged commit a5e97ed into jenkinsci:main Feb 2, 2023
@basil basil deleted the bundle branch February 2, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants