Stop bundling unnecessary libraries #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +89,10 @@ under the License. | |||
| </pluginRepositories> | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
There was a problem hiding this comment.
Why add the dependency here and exclude from apache-httpcomponents-client-4-api that already have the dependency? Why not add the commons-lang3-api at apache-httpcomponents-client-4-api?
There was a problem hiding this comment.
Why […] exclude from
apache-httpcomponents-client-4-api
I think you have misread the diff because the exclusion is from pac4j-saml, not from apache-httpcomponents-client-4-api.
kuisathaverat
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
bcprov-jdk18on-1.71.jarandcommons-lang3-3.11.jarfrom theWEB-INF/libdirectory of the HPI file in favor of the corresponding library plugins. This is the preferred mechanism for dynamic linking in the Jenkins plugin ecosystem. CC @kuisathaverat