-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pac4j to 5.2.0 #257
Conversation
I am preparing the plugin for update pac4j, first I have to merge #261 |
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
this is a major change so we have to update the major version to the next
I have resolved the conflicts and updated the major version |
I will try to make some manual testing, If I do not see anything weird, I would merge and release a new version. |
Co-authored-by: Vincent Latombe <[email protected]>
src/main/java/org/jenkinsci/plugins/saml/SamlSecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/saml/SamlSecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/saml/SamlSecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/saml/SamlProfileWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/saml/SamlRedirectActionWrapper.java
Outdated
Show resolved
Hide resolved
Summary of my tests, there is an error in the redirections 302 code is not correctly processed. The version of pac4j used is not the latest, is from about a year ago, it is possible to update to the latest with minor changes. I have added comments with the changes needed to fix the 302 redirections and bump the pac4j version to 5.4.6 I have used this environment to test the incremental https://github.com/kuisathaverat/jenkins-issues/tree/main/test-pac4j-5, it is possible to test new binaries if you copy the |
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
committed suggestions to pull them but still got things to fix (JEESessionStore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested Manually
the new pac4j-saml 5.4.6, requires an Optional "Destination" field in the SAML response to be present unless disabled with a setting
resulting in
is there a way for saml-plugin to pass this config through? |
@kuisathaverat, we are also seeing the above issue when upgrading to the latest SAML plugin version. |
@jkbszpg @rdpa-bah I am not subscribed to PR (so comments here would not arrive in my inbox). I will take a look. It is simple to add that option. To file an issue, there is a Jira instance https://issues.jenkins.io/browse/, and for questions and so on, there are several groups. Please check https://www.jenkins.io/participate/report-issue/ |
See JENKINS-69462.
This needs jenkins-infra/helpdesk#3108 to successfully be built - now it will fail because of the shibboleth artifacts.
Now that we are dropping Java 8 we can update pac4j further.
Submitter checklist