Fix optional property layout of inline help #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f:optionalProperty doesn't support the help attribute, however the underlying f:optionalBlock does. This adds a local copy of optionalProperty with the help attribute which fixes the layout.
Vlatombe
commented
May 31, 2022
| </table> | ||
| </f:entry> | ||
|
|
||
| <!-- TODO replace with f:optionalProperty once the plugin relies on a version of Jenkins with https://github.com/jenkinsci/jenkins/pull/6615 --> |
|
it is similar to jenkinsci/ssh-agents-plugin#283, on the SSH Build Plugin was resolved by enclosing everything into an entry. |
kuisathaverat
approved these changes
May 31, 2022
|
@kuisathaverat Looks like CD release did not happen. Can you relaunch it? |
|
I have to review what are the "interested" labels, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Jenkins 2.346 and later the new UI layout breaks with the current way this plugin uses optional properties. The inline help icon is misaligned and it doesn't work when clicking on it.
f:optionalPropertydoesn't support the help attribute, however theunderlying
f:optionalBlockdoes. This adds a local copy ofoptionalProperty with the help attribute which fixes the layout.
I filed in parallel jenkinsci/jenkins#6615 to fix this at core level and allow removing the local tag copy later.
Submitter checklist