Comparator Jenkins intergration #8
Conversation
…ade syntax from %-1 to %{N-1}
|
That commit is surprsingly short... Kudos! |
| return url.toString() | ||
| .replace(" ", "+") | ||
| .replace("#", "%23") | ||
| .replace(".", "%2E"); |
There was a problem hiding this comment.
There are methods which will escape the compelte url with al trics and treats in it.
There was a problem hiding this comment.
There are methods which will escape the compelte url with al trics and treats in it.
There was a problem hiding this comment.
Done, it is now using URLEncoder.encode() instead of this.
| url.append(parseToRegex(ltc.getSpliterator(), arg.split(" ")[1])); // split the arg my space and give it the second part | ||
| } else { | ||
| url.append(arg); | ||
| url.append("+"); |
There was a problem hiding this comment.
I would recomend to append by " " and then escape whole url
There was a problem hiding this comment.
I would recomend to append by " " and then escape whole url
| for (String arg : ltc.getComparatorArguments().split("\n")) { | ||
| if (arg.matches("^-+regex.*")) { | ||
| url.append("--regex+"); | ||
| url.append(parseToRegex(ltc.getSpliterator(), arg.split(" ")[1])); // split the arg my space and give it the second part |
There was a problem hiding this comment.
This looks wrong. I would do it for any arg.
My reasonings are two - 1)regex is not the onl one who would use the user query, 2) the expansion may be usefull everywhere
| replacement = splitJob[number]; | ||
| } | ||
|
|
||
| converted = converted.replaceFirst("%\\{((N-)?[0-9]+|S|SPLIT)\\}", replacement); |
There was a problem hiding this comment.
Dont forget the replace is eager. I bet we will find (in unittest O:) ) something where the eagerness maybe bite us.
Otherwise the algortihm looks good. why is there the converted=converted.repalceFirst? I thought that the matcher will aloow you to do this.
if this line will persits, then you have to remove duplicated regex declaration.
|
For many reasons I would liek to see the = x space refactoring as separate PR, but I guess that is a torture, right?-( |
...ain/java/io/jenkins/plugins/report/jtreg/main/comparator/arguments/ArgumentsDeclaration.java
Outdated
Show resolved
Hide resolved
patrikcerbak
force-pushed
the
links-to-comparator
branch
from
d52b500 to
e4ec709
Compare
patrikcerbak
changed the title
Ok, done. :) |
…e unit testing possible + changed "\n" to System.lineSeparator()
Comparator Jenkins intergration
Added a
Comparator linkssection into the Jenkins global config in which you can match a job by regex and then add multiple links to Comparator tool. Each link has a label, spliterator (a regex used to split the job name into multiple "elements") and a field to enter comparator arguments.When you enter a
--regexargument, the given value is taken and evaluated, there are some "wildcards" you can use in this query:%{X}(you can use any number in place of X) - this evaluates to the Xth element of the split job name%{N-X}(you can use any number in place of X) - this evaluates to the Xth LAST element of the split job name%{S}or%{SPLIT}- this evaluates to the spliterator expressionThe links are added to the java-reports page