Refactoring of the modules dependencies #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de in BuildReport, SuiteTestsWithResults and Test (not available in lib)
…dSummaryParser to BuildSummaryParserPlugin in plugin module
… is the only method from plugin that RecreateJtregReportSummaries needs
… no other changes for now)
…d it (also changed Report to use generics)
…ted Test factories
…lugin and deleted TestPlugin
…lugin has no duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress.
Did some refactoring to the modules to not be dependent on each other, just on the lib module. It is currently in the stage, where it works (comparator, diff and service modules are only dependant on lib, not plugin), but there is still quite a lot of work to do.