Fixed failed tests links' help prompt #38
Conversation
| <li><i>Base tool page:</i> list.html?=</li> | ||
| <li><i>Spliterator:</i> -</li> | ||
| <li><i>Tool arguments:</i> <code>-view=all-tests, -output=html, -fill, -track=%{TESTNAME} %{JOBNAME} 0, -365</code></li> | ||
| <li><i>Base tool page:</i> list.html?generated-part=&custom-part=</li> |
There was a problem hiding this comment.
Why the others do not need this? I mean the ones calling comparator?
There was a problem hiding this comment.
It has a different implementation here, it takes the base page verbatim and puts it into the url, with the comparator links, this url is hardcoded. If you wish, I can do a hardcoded dropdown list instead of this with all the possible tool webpages.
There was a problem hiding this comment.
Can you elaborate a bit more? I think I do not follow. On comaprator urls eg http://...com:9090/comp.html?generated-part=&custom-part=--compare-traces+--only-vo... There is also custom part.
I would like tohave this behavior unifed, and I would most likely like to not hardocde anything. So enforcing to use whole diff/list/.../comp.html?generated-part=&custom-part= everywhere. Those indeed may be used in some editable drop down comobox, but user must have freedom to redirect it to any custom service. wdyt?
There was a problem hiding this comment.
Thats almost how it works right now, you need to write the whole thing, eg. list.html?generated-part=&custom-part= into the field and then the arguments in the next field will be directly encoded after that (that was, as you said, to allow custom services).
My previous comment was to say that the comparator links (not touched in this PR) are automatically hardoded and the custom arguments are put after the hardcoded comp.html?generated-part=&custom-part= (I found that putting the arguments from the field after the generated-part was not working properly, but putting them after custom-part was).
There was a problem hiding this comment.
I'ms till not follwoing why comparator should be handled differently? Please unify those two... and add the dropdown box with most common usages (the four services with generated/custom parts)
There was a problem hiding this comment.
ok, i will do that
There was a problem hiding this comment.
but since i will be updating the class with the links, it will probably drop the current links again
There was a problem hiding this comment.
one more reason to have them "backjuped" as examples O:)
But no, they should not get completly lost. Thy will stop working, but the fields itself shold persist. As I see it, you will be changing just one field, and then way how to combine them together, no?
There was a problem hiding this comment.
Yes, I will be changing just one field
| <li><i>Spliterator:</i> -</li> | ||
| <li><i>Tool arguments:</i> <code>-view=all-tests, -output=html, -fill, -track=%{TESTNAME} %{JOBNAME} 0, -365</code></li> | ||
| <li><i>Base tool page:</i> list.html?generated-part=&custom-part=</li> | ||
| <li><i>Spliterator:</i> [.-]</li> |
There was a problem hiding this comment.
This do not seem right. "." is everything. So maybe "\." ?
There was a problem hiding this comment.
Afaik, when the symbols are inside of brackets, it takes the symbol as is, so the dot is really a dot, not everything. It at least works with the comparator links
There was a problem hiding this comment.
hmm.. So what do you think [\.-] did? I guess [\\.-] isimply changed to three chars of \ . and -. But with [\.-] I'm not sure.
There was a problem hiding this comment.
Afaik, when the symbols are inside of brackets, it takes the symbol as is, so the dot is really a dot
Gosh. I really did not know that. I did few checks and you are right. Where did you found that written?
There was a problem hiding this comment.
I think I found out some time on some random website when doing a school project :D
However, I always check by regexes with https://regex101.com/
There was a problem hiding this comment.
yah... I have not found it in spec... But it seems it is indeed how it works.. thanx again!
|
Is anything happening in this PR? |
|
Yes, I'm on a last (late) summer pto this week, but I will continue next week with it :) |
|
The custom links on report page can now go to any tool. There is a combobox with presets, but also a field for custom endpoint |
patrikcerbak
force-pushed
the
fixed-failed-tests-links-help
branch
from
1d8d964 to
af4105e
Compare
|
rebased changes from master - the scan passes now |
|
I tested it on my machine and the filled fields should remain after the update - the only thing that will need to be set is the "Preset tools" combobox |
Updated the failed tests links' help prompt to be accurate and 1:1 usable.