diff between two stack traces #27

patrikcerbak · 2024-04-16T15:23:27Z

Still work in progress, I need to set the links in the table to this first.

The comparator now supports creating a diff between two stack traces. It can be shown in multiple formats:

standard patch
inline view
side by side view (only in html)

There are three new command line switches:

--trace-from jobName:buildNumber -- for setting the first build
--trace-to jobName:buildNumber -- for setting the second build
--diff-format patch/inline/sidebyside -- for choosing the output format of the diff

It takes the set of tests to create the diff from the --exact-tests ".*" argument, so you also need to set it.

…nt formats

…ng the diffs

judovana · 2024-04-16T15:28:26Z

...parator/src/main/java/io/jenkins/plugins/report/jtreg/main/comparator/StackTraceCompare.java

-import io.jenkins.plugins.report.jtreg.model.Suite;
-import io.jenkins.plugins.report.jtreg.model.Test;
-import io.jenkins.plugins.report.jtreg.model.TestOutput;
+import io.jenkins.plugins.report.jtreg.model.*;


Please do not use * imports unless very necesary, which this is not.

Ahh, I will change that, my IDE did that automatically

disable that :) its evil :)

judovana · 2024-04-16T15:32:56Z

major idea... Isnt worthy to do a separate backend for this? That would be new module - as is diff and comparator, and it will be new service endpoint. ANy shared code can go t the lib, and the only shared switch is --exact-test anyway.
When I red the diff, I had issues to identify any reasn why it should stay in the comparator

judovana · 2024-04-16T15:35:19Z

Thanx a lot for rebasing. Few notes.
To add links and texts to tooltip, it may be neough to modify df848f4#diff-4c0b2eb7d59022ddbf95f75466f335e65d68ad916feabc1d2dae42315960603bR117

please drop df848f4#diff-4c0b2eb7d59022ddbf95f75466f335e65d68ad916feabc1d2dae42315960603bR99 during implementation of links. It is there jsut for you to see how to use that.

patrikcerbak · 2024-04-16T15:40:48Z

major idea... Isnt worthy to do a separate backend for this? That would be new module - as is diff and comparator, and it will be new service endpoint. ANy shared code can go t the lib, and the only shared switch is --exact-test anyway. When I red the diff, I had issues to identify any reasn why it should stay in the comparator

I can probably do that. I don't think that it would break anything and it should be easy hopefully

Thanx a lot for rebasing. Few notes. To add links and texts to tooltip, it may be neough to modify df848f4#diff-4c0b2eb7d59022ddbf95f75466f335e65d68ad916feabc1d2dae42315960603bR117

please drop df848f4#diff-4c0b2eb7d59022ddbf95f75466f335e65d68ad916feabc1d2dae42315960603bR99 during implementation of links. It is there jsut for you to see how to use that.

ok, I will take a look at that

judovana · 2024-04-16T15:44:42Z

major idea... Isnt worthy to do a separate backend for this? That would be new module - as is diff and comparator, and it will be new service endpoint. ANy shared code can go t the lib, and the only shared switch is --exact-test anyway. When I red the diff, I had issues to identify any reasn why it should stay in the comparator

I can probably do that. I don't think that it would break anything and it should be easy hopefully

of course you can do that :) But do you agree... do you think it is good idea? I htink yes, but it is just 50% of current project crew :)

patrikcerbak · 2024-04-16T15:49:47Z

major idea... Isnt worthy to do a separate backend for this? That would be new module - as is diff and comparator, and it will be new service endpoint. ANy shared code can go t the lib, and the only shared switch is --exact-test anyway. When I red the diff, I had issues to identify any reasn why it should stay in the comparator

I can probably do that. I don't think that it would break anything and it should be easy hopefully

of course you can do that :) But do you agree... do you think it is good idea? I htink yes, but it is just 50% of current project crew :)

I think it's a good idea, it makes sense to have it separately. If nothing else, then at least the code will be clearer :)

judovana · 2024-04-17T09:25:23Z

yah, the number of parametters may grow pretty much... unluckily, the haow to compare switches are shared with the comparator, pls, reuse the code.
ALso the paarsing of the shared switches should go there.

judovana · 2024-04-17T10:20:06Z

major idea... Isnt worthy to do a separate backend for this? That would be new module - as is diff and comparator, and it will be new service endpoint. ANy shared code can go t the lib, and the only shared switch is --exact-test anyway. When I red the diff, I had issues to identify any reasn why it should stay in the comparator

I can probably do that. I don't think that it would break anything and it should be easy hopefully

of course you can do that :) But do you agree... do you think it is good idea? I htink yes, but it is just 50% of current project crew :)

I think it's a good idea, it makes sense to have it separately. If nothing else, then at least the code will be clearer :)

The dealing with shared code wil be quite a pain and burden. but afaik still worthy.

patrikcerbak · 2024-04-17T11:56:24Z

yah, the number of parametters may grow pretty much... unluckily, the haow to compare switches are shared with the comparator, pls, reuse the code. ALso the paarsing of the shared switches should go there.

What switches do you mean? There are two, which both use:

--exact-tests
--formatting

So should I move them to lib (even the parsing)?

judovana · 2024-04-17T12:11:05Z

Yes please. The formatting is that type:howMuch thing?

patrikcerbak · 2024-04-17T12:22:08Z

No, that is another thing, but good catch, it also needs to be moved there.
I meant the --formatting html/color/plain switch first.

judovana · 2024-04-18T11:48:25Z

No, that is another thing, but good catch, it also needs to be moved there. I meant the --formatting html/color/plain switch first.

And --path, --jenkins-url .. and so on :(

judovana · 2024-04-22T16:47:01Z

Do you recall how our discussion or removals of parts of the trace ended? HAve we agreed on some --clean-trace replaceRegex:by argument?

…he arg parsing object oriented

…k traces (was a part of comparator before)

patrikcerbak · 2024-04-24T13:02:01Z

I extracted the common argument parsing (and everything it needs) from comparator to the lib module. I also tried to make the argument parsing object oriented now. Apart from that, I created a new module called TraceDiff with the extracted stack trace diff tool from comparator. Since the service module is not setup yet for this new tool, I haven't created any links yet :(

It can be run by:

java -cp report-jtreg-tracediff/target/report-jtreg-tracediff.jar:\
report-jtreg-lib/target/report-jtreg-lib.jar:\
$HOME/.m2/repository/com/google/code/gson/gson/2.10.1/gson-2.10.1.jar:\
$HOME/.m2/repository/io/github/java-diff-utils/java-diff-utils/4.12/java-diff-utils-4.12.jar \
io.jenkins.plugins.report.jtreg.main.tracediff.TraceDiff \
--path $HOME/.jenkins/jobs --trace-from "jenkins-test-project:210" --trace-to "jenkins-test-project:211" \
--exact-tests "runtime/modules/ModulesSymLink.java#ModulesSymLink" --formatting color --diff-format inline

…ectory

judovana · 2024-04-24T15:21:01Z

You had merged in master:( Please do not do that, rebase on top of master.

judovana · 2024-04-24T15:21:50Z

I extracted the common argument parsing (and everything it needs) from comparator to the lib module. I also tried to make the argument parsing object oriented now. Apart from that, I created a new module called TraceDiff with the extracted stack trace diff tool from comparator. Since the service module is not setup yet for this new tool, I haven't created any links yet :(

It should be easy to enbale the service . Will you, or should I?

judovana · 2024-04-24T15:24:13Z

java -cp report-jtreg-tracediff/target/report-jtreg-tracediff.jar:\
report-jtreg-lib/target/report-jtreg-lib.jar:\
$HOME/.m2/repository/com/google/code/gson/gson/2.10.1/gson-2.10.1.jar:\
$HOME/.m2/repository/io/github/java-diff-utils/java-diff-utils/4.12/java-diff-utils-4.12.jar \
io.jenkins.plugins.report.jtreg.main.tracediff.TraceDiff \
--path $HOME/.jenkins/jobs --trace-from "jenkins-test-project:210" --trace-to "jenkins-test-project:211" \
--exact-tests "runtime/modules/ModulesSymLink.java#ModulesSymLink" --formatting color --diff-format inline

Thanx! The synax is surprisngly friendly at the end!

judovana · 2024-04-24T15:32:28Z

Plese add at least one test to th new module.

judovana · 2024-04-24T15:35:25Z

Even if we push under this name (traceDiff) we have to rename. My idea is:

report-jtreg-comparator -> report-jtreg-comparator
report-jtreg-diff -> report-jtreg-list
report-jtreg-tracediff -> report-jtreg-diff

wdyt? When to do so?

patrikcerbak · 2024-04-24T15:47:08Z

You had merged in master:( Please do not do that, rebase on top of master.

Sorry for that, I didn't notice

I extracted the common argument parsing (and everything it needs) from comparator to the lib module. I also tried to make the argument parsing object oriented now. Apart from that, I created a new module called TraceDiff with the extracted stack trace diff tool from comparator. Since the service module is not setup yet for this new tool, I haven't created any links yet :(

It should be easy to enbale the service . Will you, or should I?

I can try to take a look at that :)

Plese add at least one test to th new module.

ok, will do

Even if we push under this name (traceDiff) we have to rename. My idea is:
report-jtreg-comparator -> report-jtreg-comparator
report-jtreg-diff -> report-jtreg-list
report-jtreg-tracediff -> report-jtreg-diff
wdyt? When to do so?

I can do that in this PR if you want that

judovana · 2024-04-24T16:13:46Z

I can try to take a look at that :)

+

I can do that in this PR if you want that

== go for it, at least from scope of renaming the modules and variaous pom artifacts.

Me as downstream, will have a bit of fun with that, but it will be worthy. Also the links pointing to the current diff on hydra will needaadjsut (have we already made them adjsutable? If not, it will be mandatory work to do togehter with traceDiff links)

The name diff is used in the service wrapper scripts, and that will need to follow that too. Also it is used in the service endpint name, ut I'm +1 to fix that sooner rather then later.

So feel free to procedd with reanming up to where you feel safe, and then lts stop, merge, and continue separately.

patrikcerbak · 2024-05-23T15:05:10Z

The renaming of the modules is (hopefully correctly without any problems) done.

diff module was changed to list
traceDiff was changed to diff

Also, the endpoint of the former diff's service was changed from /diff.html to /list.html.

judovana · 2024-05-23T15:54:42Z

Jsut recall me, current "list" is my old tool. Curren report-jtreg-comparator is your new comaprator which can comapre test results and traces. and current diff is the newest module, which is showing the diff between traes. oook?

judovana · 2024-05-23T15:55:08Z

If so, then lets keep it like that. Its good enough.

patrikcerbak · 2024-05-23T16:04:53Z

Jsut recall me, current "list" is my old tool. Curren report-jtreg-comparator is your new comaprator which can comapre test results and traces. and current diff is the newest module, which is showing the diff between traes. oook?

yes, exactly

judovana · 2024-05-23T16:14:47Z

ty!

patrikcerbak added 3 commits April 16, 2024 17:14

added the option to create a diff between two stack traces in differe…

cd4eaf5

…nt formats

fixed line breaks in the html formatter

2fde111

added --trace-from, --trace-to and --diff-format arguments for creati…

baa0750

…ng the diffs

patrikcerbak requested a review from a team as a code owner April 16, 2024 15:23

judovana reviewed Apr 16, 2024

View reviewed changes

judovana force-pushed the master branch from f4597a0 to be6ff5f Compare April 22, 2024 16:24

judovana and others added 3 commits April 24, 2024 15:00

Added real links to html tooltips

d73722b

exported common arguments from the comparator module into lib, made t…

e3daa6c

…he arg parsing object oriented

created TraceDiff module which is for creating the diffs between stac…

b7e31da

…k traces (was a part of comparator before)

moved StackTraceTools to utils package to clean up the parent lib dir…

fda52d2

…ectory

patrikcerbak added 3 commits May 6, 2024 14:49

created a ui for the trace diff to the service module

7896bef

fixed the tracediff's version in pom.xml

6a6ee68

renamed modules and endpoints: diff->list, traceDiff->diff

064a351

judovana changed the title ~~[WIP] diff between two stack traces~~ diff between two stack traces Jun 3, 2024

judovana merged commit b5e2b5d into jenkinsci:master Jun 3, 2024
13 checks passed

patrikcerbak deleted the diff-between-traces branch June 19, 2024 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

diff between two stack traces #27

diff between two stack traces #27

patrikcerbak commented Apr 16, 2024

judovana Apr 16, 2024

patrikcerbak Apr 16, 2024

judovana Apr 16, 2024

judovana commented Apr 16, 2024

judovana commented Apr 16, 2024

patrikcerbak commented Apr 16, 2024

judovana commented Apr 16, 2024

patrikcerbak commented Apr 16, 2024

judovana commented Apr 17, 2024 •

edited

Loading

judovana commented Apr 17, 2024

patrikcerbak commented Apr 17, 2024

judovana commented Apr 17, 2024

patrikcerbak commented Apr 17, 2024

judovana commented Apr 18, 2024

judovana commented Apr 22, 2024 •

edited

Loading

patrikcerbak commented Apr 24, 2024

judovana commented Apr 24, 2024

judovana commented Apr 24, 2024 •

edited

Loading

judovana commented Apr 24, 2024 •

edited

Loading

judovana commented Apr 24, 2024

judovana commented Apr 24, 2024

patrikcerbak commented Apr 24, 2024

judovana commented Apr 24, 2024 •

edited

Loading

patrikcerbak commented May 23, 2024

judovana commented May 23, 2024

judovana commented May 23, 2024

patrikcerbak commented May 23, 2024

judovana commented May 23, 2024

diff between two stack traces #27

diff between two stack traces #27

Conversation

patrikcerbak commented Apr 16, 2024

Still work in progress, I need to set the links in the table to this first.

judovana Apr 16, 2024

Choose a reason for hiding this comment

patrikcerbak Apr 16, 2024

Choose a reason for hiding this comment

judovana Apr 16, 2024

Choose a reason for hiding this comment

judovana commented Apr 16, 2024

judovana commented Apr 16, 2024

patrikcerbak commented Apr 16, 2024

judovana commented Apr 16, 2024

patrikcerbak commented Apr 16, 2024

judovana commented Apr 17, 2024 • edited Loading

judovana commented Apr 17, 2024

patrikcerbak commented Apr 17, 2024

judovana commented Apr 17, 2024

patrikcerbak commented Apr 17, 2024

judovana commented Apr 18, 2024

judovana commented Apr 22, 2024 • edited Loading

patrikcerbak commented Apr 24, 2024

judovana commented Apr 24, 2024

judovana commented Apr 24, 2024 • edited Loading

judovana commented Apr 24, 2024 • edited Loading

judovana commented Apr 24, 2024

judovana commented Apr 24, 2024

patrikcerbak commented Apr 24, 2024

judovana commented Apr 24, 2024 • edited Loading

patrikcerbak commented May 23, 2024

judovana commented May 23, 2024

judovana commented May 23, 2024

patrikcerbak commented May 23, 2024

judovana commented May 23, 2024

judovana commented Apr 17, 2024 •

edited

Loading

judovana commented Apr 22, 2024 •

edited

Loading

judovana commented Apr 24, 2024 •

edited

Loading

judovana commented Apr 24, 2024 •

edited

Loading

judovana commented Apr 24, 2024 •

edited

Loading