Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links of web ui elements #17

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fixed links of web ui elements #17

merged 2 commits into from
Dec 4, 2023

Conversation

judovana
Copy link
Contributor

During testing of this fix I had noticed, the new global compare links throws NPE. Thus I ahd intialised thema s another commit.
I'm nto sure it is fix or workaround. Also I had noticed that thr (x) removal button do actually nothing. Not sure if your fault or sts jenkins temporary issue, or my initialisation issue....

Maybe it would be better to if(!null) the getters. Will leave the fullfix to you.

Note, that I'm not sure if it is fix or workaround.
Not, that it misbehaved for me completly - the items added in config
could not be removed in  2.434(.1) STS jenkins
renamed settings to jtreg as it should be
@judovana judovana requested a review from a team as a code owner November 30, 2023 14:05
@judovana judovana requested review from patrikcerbak and removed request for a team November 30, 2023 14:05
Copy link
Collaborator

@patrikcerbak patrikcerbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes, although a bit difficult for me at first glance, are looking good to me. It makes sense this way.

@judovana
Copy link
Contributor Author

judovana commented Dec 4, 2023

ty

@judovana judovana merged commit 0293cb5 into master Dec 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants