[FIXED JENKINS-36991] Do not give up on classloading if loading is interrupted #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terrupted while fetching ClassRefference
olivergondza
changed the title
| } | ||
|
|
||
| ref.rememberIn(cn, ref.classLoader); | ||
| // no code is allowed to reach here |
There was a problem hiding this comment.
You have pointed me to the fact I do not propagate exception correctly in the catch. Though, after that is fixed, javac do not let me place the statement here as it will be unreachable statement.
olivergondza
force-pushed
the
JENKINS-36991
branch
from
1f2eed1
to
5f24dcd
Compare
|
Updated. Ws-ignoring diff: https://github.com/jenkinsci/remoting/pull/94/files?w=1 |
|
Looks good to me 👍 |
|
LGTM, too |
oleg-nenashev
added a commit
that referenced
this pull request
Aug 5, 2016
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
Aug 6, 2016
Fixed issues: * [JENKINS-37140](https://issues.jenkins-ci.org/browse/JENKINS-37140) - JNLP Slave connection issue with *JNLP3-connect* protocol when the generated encrypted cookie contains a newline symbols. (jenkinsci/remoting#95) * [JENKINS-36991](https://issues.jenkins-ci.org/browse/JENKINS-36991) - Unable to load class when remote classloader gets interrupted. (jenkinsci/remoting#94) Enhancements: * Improve diagnostics for Jar Cache write errors. (jenkinsci/remoting#91)
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Aug 6, 2016
Fixed issues: * [JENKINS-37140](https://issues.jenkins-ci.org/browse/JENKINS-37140) - JNLP Slave connection issue with *JNLP3-connect* protocol when the generated encrypted cookie contains a newline symbols. (jenkinsci/remoting#95) * [JENKINS-36991](https://issues.jenkins-ci.org/browse/JENKINS-36991) - Unable to load class when remote classloader gets interrupted. (jenkinsci/remoting#94) Enhancements: * Improve diagnostics for Jar Cache write errors. (jenkinsci/remoting#91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… while fetching ClassRefference
Fixing JENKINS-36991, a variant of JENKINS-19453.
@jenkinsci/code-reviewers (esp. @jglick and @kohsuke)