-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-36871] JNLPProtocol4 #92
Commits on Jul 22, 2016
-
[JENKINS-36871] Replace Charset.forName("UTF-8") with a constant from…
… a utility class
Configuration menu - View commit details
-
Copy full SHA for 8656468 - Browse repository at this point
Copy the full SHA 8656468View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc00197 - Browse repository at this point
Copy the full SHA fc00197View commit details -
[JENKINS-36871] Need a
SettableFuture
andListenableFuture
withou……t relying on external dependencies
Configuration menu - View commit details
-
Copy full SHA for 3aa27ec - Browse repository at this point
Copy the full SHA 3aa27ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e3f300 - Browse repository at this point
Copy the full SHA 0e3f300View commit details -
Configuration menu - View commit details
-
Copy full SHA for a10785b - Browse repository at this point
Copy the full SHA a10785bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 960ea6e - Browse repository at this point
Copy the full SHA 960ea6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82f43c7 - Browse repository at this point
Copy the full SHA 82f43c7View commit details -
[JENKINS-36871] Need some stream adapters to help with our ByteBuffer…
…CommandTransport optimized implementation - The original implementation we had could not access some of the required methods due to being outside of the `hudson.remoting` package, so we didn't need these wrappers
Configuration menu - View commit details
-
Copy full SHA for c3e3262 - Browse repository at this point
Copy the full SHA c3e3262View commit details
Commits on Jul 27, 2016
-
[JENKINS-36871] Add support for
mark(limit)
to the input stream- Some of the tests require JUnit 4.12
Configuration menu - View commit details
-
Copy full SHA for 3707dfc - Browse repository at this point
Copy the full SHA 3707dfcView commit details -
[JENKINS-36871] Sync with latest version containing fix for NPE that …
…occurs in "fast" protocols
Configuration menu - View commit details
-
Copy full SHA for 402973c - Browse repository at this point
Copy the full SHA 402973cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b42be51 - Browse repository at this point
Copy the full SHA b42be51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f2ef5d - Browse repository at this point
Copy the full SHA 9f2ef5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f477f - Browse repository at this point
Copy the full SHA 26f477fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2923f11 - Browse repository at this point
Copy the full SHA 2923f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 791292b - Browse repository at this point
Copy the full SHA 791292bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06d9710 - Browse repository at this point
Copy the full SHA 06d9710View commit details -
[JENKINS-36871] Add the v1 basic stress tester
- Resurected from history as we will be forced to diverge to map against the JNLPProtocol APIs rather than follow the nicer implementation path from CJOC
Configuration menu - View commit details
-
Copy full SHA for 509ac4f - Browse repository at this point
Copy the full SHA 509ac4fView commit details
Commits on Jul 29, 2016
-
[JENKINS036871] Refactoring the API for protocols to make it symmetri…
…c within remoting - rather than having one half of the protocol in jenkins and the other half in remoting. - I need to write tests for this and then remote the old classes
Configuration menu - View commit details
-
Copy full SHA for ff0f070 - Browse repository at this point
Copy the full SHA ff0f070View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c8b49f - Browse repository at this point
Copy the full SHA 4c8b49fView commit details
Commits on Aug 2, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 124439e - Browse repository at this point
Copy the full SHA 124439eView commit details -
[JENKINS-36871] Tests had missed some critical bugs in this ByteBuffe…
…rQueueInputStream
Configuration menu - View commit details
-
Copy full SHA for 707bfe8 - Browse repository at this point
Copy the full SHA 707bfe8View commit details -
[JENKINS-36871] Unnecessary reset of length
- Also causes commands that span multiple frames to be corrupted
Configuration menu - View commit details
-
Copy full SHA for 7062224 - Browse repository at this point
Copy the full SHA 7062224View commit details -
[JENKINS-36871] Found an infinite loop under certain error state disc…
…onnects - Don't think this affected any real protocols, but better to fix after finding
Configuration menu - View commit details
-
Copy full SHA for 90425ad - Browse repository at this point
Copy the full SHA 90425adView commit details -
[JENKINS-36871] Slightly faster code path to get hex conversion
- Avoids intermediate String representation. Could probably get faster still with BigInteger and zero-left-pad but it becomes harder to understand
Configuration menu - View commit details
-
Copy full SHA for d2504bc - Browse repository at this point
Copy the full SHA d2504bcView commit details
Commits on Aug 3, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0ef5cac - Browse repository at this point
Copy the full SHA 0ef5cacView commit details -
[JENKINS-36871] When tiered compilation kicks in, sometimes you can g…
…et concurrent modification exceptions - They'll recover, but better is not to have to worry about it at all
Configuration menu - View commit details
-
Copy full SHA for adc6014 - Browse repository at this point
Copy the full SHA adc6014View commit details -
[JENKINS-36871] Suppress extra socket connection when all protocols h…
…ave been tried - Also better setup of the SSLContext
Configuration menu - View commit details
-
Copy full SHA for 9ad1ed1 - Browse repository at this point
Copy the full SHA 9ad1ed1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a065e8a - Browse repository at this point
Copy the full SHA a065e8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6449a73 - Browse repository at this point
Copy the full SHA 6449a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb6354 - Browse repository at this point
Copy the full SHA 8bb6354View commit details -
[JENKINS-36871] Don't spam the logs with warnings for closed I/O or r…
…efused connections
Configuration menu - View commit details
-
Copy full SHA for a6e45c5 - Browse repository at this point
Copy the full SHA a6e45c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ac6dc3 - Browse repository at this point
Copy the full SHA 0ac6dc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d999b95 - Browse repository at this point
Copy the full SHA d999b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc646c3 - Browse repository at this point
Copy the full SHA fc646c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for aae74ae - Browse repository at this point
Copy the full SHA aae74aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d003c8 - Browse repository at this point
Copy the full SHA 7d003c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38cd6e4 - Browse repository at this point
Copy the full SHA 38cd6e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbb5865 - Browse repository at this point
Copy the full SHA bbb5865View commit details -
Configuration menu - View commit details
-
Copy full SHA for d40ca3d - Browse repository at this point
Copy the full SHA d40ca3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc69f2 - Browse repository at this point
Copy the full SHA 4bc69f2View commit details
Commits on Aug 5, 2016
-
[JENKINS-36871] Allow a filter to call
completed()
from both the re……ceive and send sides without bombing out. Prevents stack traces such as ``` Exception in thread "main" java.lang.IllegalStateException: Filter has already been completed at org.jenkinsci.remoting.protocol.FilterLayer.completed(FilterLayer.java:106) at org.jenkinsci.remoting.protocol.impl.ConnectionHeadersFilterLayer.complete(ConnectionHeadersFilterLayer.java:365) at org.jenkinsci.remoting.protocol.impl.ConnectionHeadersFilterLayer.doSend(ConnectionHeadersFilterLayer.java:498) at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.doSend(ProtocolStack.java:691) at org.jenkinsci.remoting.protocol.ApplicationLayer.write(ApplicationLayer.java:157) at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.start(ChannelApplicationLayer.java:226) at org.jenkinsci.remoting.protocol.ProtocolStack.init(ProtocolStack.java:202) at org.jenkinsci.remoting.protocol.ProtocolStack.access$700(ProtocolStack.java:107) at org.jenkinsci.remoting.protocol.ProtocolStack$Builder.build(ProtocolStack.java:555) at org.jenkinsci.remoting.engine.JnlpProtocol4PlainHandler.connect(JnlpProtocol4PlainHandler.java:149) at org.jenkinsci.remoting.engine.JnlpProtocolHandler.connect(JnlpProtocolHandler.java:140) at org.jenkinsci.remoting.engine.HandlerLoopbackLoadStress.startClient(HandlerLoopbackLoadStress.java:466) at org.jenkinsci.remoting.engine.HandlerLoopbackLoadStress.main(HandlerLoopbackLoadStress.java:426) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) ```
Configuration menu - View commit details
-
Copy full SHA for 75c4cf7 - Browse repository at this point
Copy the full SHA 75c4cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6da1cb4 - Browse repository at this point
Copy the full SHA 6da1cb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d942165 - Browse repository at this point
Copy the full SHA d942165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b291b3 - Browse repository at this point
Copy the full SHA 4b291b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd9145 - Browse repository at this point
Copy the full SHA 6cd9145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74bf4fa - Browse repository at this point
Copy the full SHA 74bf4faView commit details -
[JENKINS-36871] Stripped back higher performance ByteBufferQueue Inpu…
…tStream implementation - Drops support for mark and unbounded read in return for faster performance
Configuration menu - View commit details
-
Copy full SHA for 8e595fc - Browse repository at this point
Copy the full SHA 8e595fcView commit details -
[JENKINS-36871] Switch to FastByteBufferQueueInputStream
- We don't need the general purpose mark support or unbounded reads, so lets get more performance
Configuration menu - View commit details
-
Copy full SHA for 3c0db40 - Browse repository at this point
Copy the full SHA 3c0db40View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5656c0 - Browse repository at this point
Copy the full SHA b5656c0View commit details -
[JENKINS-36871] Blocking I/O is faster when you have very few connect…
…ions, so allow preference declaration
Configuration menu - View commit details
-
Copy full SHA for 1edda2b - Browse repository at this point
Copy the full SHA 1edda2bView commit details -
[JENKINS-36871] The code was missing a NOTICE and LICENSE files
- You'll see why I spotted this next
Configuration menu - View commit details
-
Copy full SHA for c8be845 - Browse repository at this point
Copy the full SHA c8be845View commit details -
[JENKINS-36871] Add a load testing client
- This needs its own LICENSE and NOTICE files as it includes things like JUnit
Configuration menu - View commit details
-
Copy full SHA for 19093e3 - Browse repository at this point
Copy the full SHA 19093e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41841e5 - Browse repository at this point
Copy the full SHA 41841e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0529c15 - Browse repository at this point
Copy the full SHA 0529c15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce2f8a - Browse repository at this point
Copy the full SHA 2ce2f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac9bcab - Browse repository at this point
Copy the full SHA ac9bcabView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce597c3 - Browse repository at this point
Copy the full SHA ce597c3View commit details
Commits on Aug 7, 2016
-
Configuration menu - View commit details
-
Copy full SHA for b753232 - Browse repository at this point
Copy the full SHA b753232View commit details
Commits on Aug 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 75b173a - Browse repository at this point
Copy the full SHA 75b173aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cea38c - Browse repository at this point
Copy the full SHA 2cea38cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb802b7 - Browse repository at this point
Copy the full SHA fb802b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for debffee - Browse repository at this point
Copy the full SHA debffeeView commit details
Commits on Aug 9, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3275213 - Browse repository at this point
Copy the full SHA 3275213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d98828 - Browse repository at this point
Copy the full SHA 3d98828View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3631af - Browse repository at this point
Copy the full SHA e3631afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04ec717 - Browse repository at this point
Copy the full SHA 04ec717View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d8400 - Browse repository at this point
Copy the full SHA 58d8400View commit details -
[JENKINS-36871] Expose the enum
- though this technically is OK as protected or package scope as any derived classes can implement and Enum is a public class so there is a parent type that people can reference
Configuration menu - View commit details
-
Copy full SHA for c7f2c9c - Browse repository at this point
Copy the full SHA c7f2c9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a9530f - Browse repository at this point
Copy the full SHA 5a9530fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da8a85 - Browse repository at this point
Copy the full SHA 7da8a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b8cf1 - Browse repository at this point
Copy the full SHA a9b8cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6168a6 - Browse repository at this point
Copy the full SHA c6168a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e406ea8 - Browse repository at this point
Copy the full SHA e406ea8View commit details
Commits on Aug 11, 2016
-
[JENKINS-37302] Experiment seems to show that this fixes the failures
- Of course we are now weakening the equality test, but since this has come through the cipher this shouldn't be too bad.
Configuration menu - View commit details
-
Copy full SHA for 3bb5f48 - Browse repository at this point
Copy the full SHA 3bb5f48View commit details -
[JENKINS-37302] Follow-up on cookie mangling
- Found another set of cases where the cookie gets mangled, as the EngineUtil.readLine does a `.trim()` If the encrypted cookie happens to being or end with a whitespace character... boom A first order analysis looks only at the single bytes that could be whitespace. There are 9 such bytecodes, but that includes `\n` which we have already tested for So there is an 8 in 256 or 1 in 32 chance that the first character is whitespace There is a 31 in 32 chance that it is not and a 1 in 32 chance that the last is whitespace Thus (1/32 + 32/32*1/32) = 6%... or in total 28% of the time the generated cookies will be unusable with the current handshaking ciphers - Also stop creating throw-away instances of `SecureRandom` because that is a waste
Configuration menu - View commit details
-
Copy full SHA for 5566751 - Browse repository at this point
Copy the full SHA 5566751View commit details -
[JENKINS-36871] Remove excessive synchronization and rollback findbug…
…s introduced bug - We don't want to synchronize as that will cause issues during the close. We can rely on the stack for ensuring that reads are serialized and writes are serialized and the `channel` field is write once with the write guarded by the synchronized setup method
Configuration menu - View commit details
-
Copy full SHA for 926307a - Browse repository at this point
Copy the full SHA 926307aView commit details -
[JENKINS-36871] Fix flaky test
- On machines with fewer cores than my machine, the selector thread may not have processed the interest removal and hence the test can fail randomly for lower spec machines
Configuration menu - View commit details
-
Copy full SHA for 247f15b - Browse repository at this point
Copy the full SHA 247f15bView commit details