Ensure a message is logged if we can not create an override #80

jtnord · 2016-04-11T16:46:11Z

If the first access of the ClassFilter is from a class being auto wired
then the root cause of the Issue can get swallowed and it is not clear in
the logs what is wrong. So if something goes wrong always log the error
at the expense that it gets logged twice (which is not a bad thing as it
is fatal anyway and will cause Jenkins to pretty much not work at all)

@reviewbybees

If the first access of the ClassFilter is from a class being auto wired then the root cause of the Issue can get swallowed and it is not clear in the logs what is wrong. So if something goes wrong always log the error at the expense that it gets logged twice (which is not a bad thing as it is fatal anyway and will cause Jenkins to pretty much not work at all)

ghost · 2016-04-11T16:46:47Z

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

kzantow · 2016-04-11T17:12:40Z

🐝

jenkinsadmin · 2016-04-11T18:03:49Z

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

mslusarczyk · 2016-04-12T10:21:33Z

🐝

jtnord · 2016-04-12T10:46:46Z

@reviewbybees done

ghost · 2016-04-12T16:42:44Z

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

oleg-nenashev · 2016-04-13T21:39:21Z

src/main/java/hudson/remoting/ClassFilter.java

+        }
+        catch (Error e) {
+            // when being used by something like XStream the actual cause gets swallowed
+            LOGGER.log(Level.SEVERE, "Failed to initialize the default class filter", e);


I'm not a big fan of this construct, because it may hide the original OOM if a new one happens within Logger listeners. But good for other error types

this happens early on so if we are OOM there then wehey...
now you can argue this should be Throwable or a specific Error should be thrown.
or even a big fat 🐛 that List<Pattern> patternOverride = loadPatternOverride(); should be inside the try block.

oleg-nenashev · 2016-04-13T21:39:39Z

🐝 with a corner-case grumbling

jtnord · 2016-04-13T22:05:08Z

🐛 on my own code... it's late and I need to take a look tomorrow, but despite all the positive reviews I think this is not correct.

oleg-nenashev · 2016-05-13T15:51:59Z

@jtnord any plans?
May be a subject for backporting

jtnord · 2016-05-13T16:37:22Z

@oleg-nenashev need to fix it up, need to get some other bits done first so no a huge priority for me right now.

oleg-nenashev · 2016-05-13T18:16:15Z

Sure, thanks for update!

oleg-nenashev · 2016-06-06T13:20:53Z

@jtnord Would be great to get it integrated by the end of this week. I'm planning a new release, which may still get into the LTS

jtnord · 2016-06-09T10:02:35Z

removing my own bug with a 🐝

oleg-nenashev · 2016-06-09T10:05:53Z

🐝 from me

amuniz · 2016-06-09T10:37:14Z

🐝

jtnord · 2016-06-09T10:55:41Z

@reviewbybees done (again)

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80)

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80) (cherry picked from commit c718516)

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80)

jglick · 2017-03-14T13:18:01Z

FTR this looks like JDK-8051847.

oleg-nenashev reviewed Apr 13, 2016
View reviewed changes

oleg-nenashev added needs-fix work-in-progress labels Apr 20, 2016

Move the loading of the pattern override into the try block

7be1d81

jtnord added needs-review and removed needs-fix work-in-progress labels Jun 9, 2016

jtnord added ready-to-merge and removed needs-review labels Jun 9, 2016

oleg-nenashev merged commit f18c44e into jenkinsci:master Jun 9, 2016

oleg-nenashev mentioned this pull request Jun 10, 2016

Update remoting to 2.60 jenkinsci/jenkins#2403

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure a message is logged if we can not create an override #80

Ensure a message is logged if we can not create an override #80

jtnord commented Apr 11, 2016

ghost commented Apr 11, 2016

kzantow commented Apr 11, 2016

jenkinsadmin commented Apr 11, 2016

mslusarczyk commented Apr 12, 2016

jtnord commented Apr 12, 2016

ghost commented Apr 12, 2016

oleg-nenashev Apr 13, 2016

jtnord Apr 13, 2016

oleg-nenashev commented Apr 13, 2016

jtnord commented Apr 13, 2016

oleg-nenashev commented May 13, 2016

jtnord commented May 13, 2016

oleg-nenashev commented May 13, 2016

oleg-nenashev commented Jun 6, 2016

jtnord commented Jun 9, 2016

oleg-nenashev commented Jun 9, 2016

amuniz commented Jun 9, 2016

jtnord commented Jun 9, 2016

jglick commented Mar 14, 2017

Ensure a message is logged if we can not create an override #80

Ensure a message is logged if we can not create an override #80

Conversation

jtnord commented Apr 11, 2016

ghost commented Apr 11, 2016

kzantow commented Apr 11, 2016

jenkinsadmin commented Apr 11, 2016

mslusarczyk commented Apr 12, 2016

jtnord commented Apr 12, 2016

ghost commented Apr 12, 2016

oleg-nenashev Apr 13, 2016

Choose a reason for hiding this comment

jtnord Apr 13, 2016

Choose a reason for hiding this comment

oleg-nenashev commented Apr 13, 2016

jtnord commented Apr 13, 2016

oleg-nenashev commented May 13, 2016

jtnord commented May 13, 2016

oleg-nenashev commented May 13, 2016

oleg-nenashev commented Jun 6, 2016

jtnord commented Jun 9, 2016

oleg-nenashev commented Jun 9, 2016

amuniz commented Jun 9, 2016

jtnord commented Jun 9, 2016

jglick commented Mar 14, 2017