Trying to guide people away from implementing RoleSensitive manually

[jglick]

After about the seventeenth Jenkins plugin pull request (most recently jenkinsci/analysis-core-plugin#31) featuring something like

@Override
public void checkRoles(RoleChecker checker) throws SecurityException {
    // TODO what do we need to do here?
}

I am trying to guide people to the answer, in case they read Javadoc anyway.

(For SECURITY-144 we explicitly decided to introduce RoleSensitive despite the source incompatibility, while keeping a binary-compatible runtime behavior, since every plugin author really must decide how a given callable is intended to be used.)

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[KostyaSha]

👍

[recena]

🐝

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[vjuranek]

👍 (being one who got confused by javadoc, thanks @jglick for pointing out all wrong commits!)

[vjuranek]

btw: I would consider also adding a link to corresponding wiki page to provide more information for those who are interested in more details or are still unsure what to do.

[jtnord]

🐝