Skip to content

Commit

Permalink
Remove debugging; don't check for existing path
Browse files Browse the repository at this point in the history
  • Loading branch information
bklang committed Mar 24, 2011
1 parent 9a52962 commit 31fc285
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
3 changes: 0 additions & 3 deletions src/main/java/hudson/plugins/rake/Rake.java
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,12 @@ public boolean perform(AbstractBuild<?,?> build, Launcher launcher, BuildListene
try {
EnvVars env = build.getEnvironment(listener);
if (rake != null) {
System.out.println("Rake GEM HOME: "+ rake.getGemHome());
if (rake.getGemHome() != null) {
env.put("GEM_HOME", rake.getGemHome());
}
System.out.println("Rake GEM PATH: "+ rake.getGemPath());
if (rake.getGemPath() != null) {
env.put("GEM_PATH", rake.getGemPath());
}
System.err.println("Rake Bin PATH: "+ rake.getBinPath());
if (rake.getBinPath() != null) {
StringBuilder builder = new StringBuilder();
String path = env.get("PATH");
Expand Down
9 changes: 1 addition & 8 deletions src/main/java/hudson/plugins/rake/RvmUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,7 @@ public static RubyInstallation[] getRvmRubies(Rvm rvm) {
// Add GEM bin directory to path
newpath = newpath.concat(File.pathSeparator).concat(new File(ruby.getGemHome(), "bin").getCanonicalPath());

// Create or append the calculated path for this Ruby install
path = ruby.getBinPath();
if (path == null || path.length() == 0) {
path = newpath;
} else {
path = path.concat(File.pathSeparator).concat(newpath);
}
ruby.setBinPath(path);
ruby.setBinPath(newpath);

rubies.add(ruby);
}
Expand Down

2 comments on commit 31fc285

@alanharder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a few commits several months ago in rake-plugin.. want to run a new release? (or I can do this)

@bklang
Copy link
Contributor Author

@bklang bklang commented on 31fc285 Aug 8, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know how to make a release. These patches were contributed to David Calavera, who merged them on my behalf. I am pretty sure he has rolled a release since then, but I'm not completely certain.

Please sign in to comment.