Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress future spotbugs warning for equals test #350

Merged

Conversation

MarkEWaite
Copy link
Contributor

Suppress future spotbugs warning for equals test

Floating point equality test in this case is reasonable since it is being used in a compareTo method.

Testing done

Confirmed the suppressed warning is no longer reported.

Submitter checklist

Preview Give feedback

Floating point equality test in this case is reasonable since it is
being used in a compareTo method.
@MarkEWaite MarkEWaite requested a review from a team as a code owner May 9, 2024 16:36
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label May 9, 2024
@MarkEWaite MarkEWaite merged commit cf8e254 into jenkinsci:master May 9, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the avoid-future-spotbugs-warning branch June 18, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant