Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versions from plugin BOM #56

Closed

Conversation

MarkEWaite
Copy link

Use plugin versions from plugin BOM

Better to rely on the compatibility testing of the plugin BOM than to maintain the version numbers in the plugin pom directly.

Use most recent version of testcontainers

Retain old conditional-buildstep version because there is a breaking change in later releases. If tests pass on ci.jenkins.io with these changes, I can evaluate the difficulty of handling the breaking change in the conditional-buildstep

Testing done

Unit tests pass. Integration tests seem to hang on my Debian and Ubuntu computers. Will rely on ci.jenkins.io to run the integration tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@froque froque closed this Sep 12, 2024
@MarkEWaite MarkEWaite deleted the rely-on-plugin-versions-from-bom branch September 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants