Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single instance of PluginUsageModel in jelly to cache analyze results #44

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Use a single instance of PluginUsageModel in jelly to cache analyze results #44

merged 1 commit into from
Jun 28, 2023

Conversation

froque
Copy link
Member

@froque froque commented Jun 28, 2023

PluginUsageModel uses the same collector in all 3 methods to improve performance by caching results in a internal hashmap.

But jelly was instantiating a new PluginUsageModel for getOtherPlugins method call.

It should help with JENKINS-71329 Plugin Usage page not loading

Testing done

Submitter checklist
Preview Give feedback

@froque
Use a single instance of PluginUsageModel in jelly to cache analyze r…
e22b9b3 
…esults

PluginUsageModel uses the same collector in all 3 methods to improve
performance by caching results in a internal hashmap.

But jelly was instantiating a new PluginUsageModel for getOtherPlugins
method call.
@froque froque merged commit 25fe2ce into master Jun 28, 2023
@froque froque deleted the remove_duplicate_analyze branch June 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@froque