Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0 #423

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 12, 2021

Bumps spotbugs-maven-plugin from 4.2.3 to 4.3.0.

Commits
  • 5530040 [maven-release-plugin] prepare release spotbugs-maven-plugin-4.3.0
  • a32d2b3 [pom] Bump junit to 5.7.2
  • 8a31260 Merge pull request #336 from hazendaz/spotbugs
  • c9733e9 [pom] Bump spotbugs to 4.3.0
  • 92876e8 [pom] Remove old maven comment as we are now going to latest 3.8.1
  • 8ebfd75 [ci] Update since date as we switched to 4.3.x
  • e8e34a4 Merge pull request #334 from spotbugs/dependabot/maven/slf4jVersion-2.0.0-alpha2
  • 6891b9d Merge pull request #311 from spotbugs/dependabot/maven/mavenVersion-3.8.1
  • 1d7f14c Merge pull request #312 from spotbugs/dependabot/maven/org.apache.maven-maven...
  • 7ba7755 Merge pull request #335 from spotbugs/dependabot/maven/com.github.spotbugs-sp...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.2.3 to 4.3.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.2.3...spotbugs-maven-plugin-4.3.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 12, 2021
@jglick jglick merged commit a59ab44 into master Jul 19, 2021
@dependabot dependabot bot deleted the dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.3.0 branch July 19, 2021 15:07
@basil
Copy link
Member

basil commented Jul 22, 2021

FYI this new version of SpotBugs is throwing a lot of new warnings for EI_EXPOSE_REP/EI_EXPOSE_REP2 in all my plugins (which makes the build unstable). I haven't investigated yet to see if there is a straightforward way to fix the warnings or if they are false positives.

@Vlatombe
Copy link
Member

@jglick
Copy link
Member

jglick commented Jul 22, 2021

@jglick
Copy link
Member

jglick commented Jul 22, 2021

Yeah the first one I looked at was an assignment of an OutputStream to a field—obviously as designed. Another case was assigning a Run to a field—again, exactly what was meant. There are other cases where a List<String> is returned from a field which could be locked down with a new ArrayList<>(strings) if you were being paranoid but in practice is not a problem in most scenarios so long as the method is not being used as an API between components. I agree this is mostly noise. Really I think SpotBugs should treat these as low priority, not medium. You can create a per-project src/spotbugs/excludesFilter.xml but I am inclined to just revert this dependency bump for now and file a bug upstream to change the priority; WDYT?

@basil
Copy link
Member

basil commented Jul 22, 2021

I am inclined to just revert this dependency bump for now and file a bug upstream to change the priority; WDYT?

I concur. I would be surprised if we were the only folks that complained about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants