CI improvements #253
CI improvements #253
Conversation
| // TODO Azure mirror | ||
| ansiColor('xterm') { | ||
| withEnv(['MAVEN_OPTS=-Djansi.force=true']) { | ||
| sh 'mvn -B -Dstyle.color=always -ntp -Prun-plugin-pom-its clean verify' |
There was a problem hiding this comment.
Could we use runMaven instead? Mirros & Co
There was a problem hiding this comment.
runMaven does not set up mirrors, nor has it been updated for -ntp, and does a bunch of stuff which is useless in an ACI agent. I prefer to keep things more transparent and explicit.
There was a problem hiding this comment.
runMaven does not set up mirrors, nor has it been updated for -ntp, and does a bunch of stuff which is useless in an ACI agent
Hm? https://github.com/jenkins-infra/pipeline-library/blob/master/vars/infra.groovy#L69-L89
Maybe you are talking about the Pipeline Maven Plugin. Sorry, I meant infra.runMaven. We can add -ntp there and any ACI agent tweaks if needed there
There was a problem hiding this comment.
Can be done in a follow-up, though I would still prefer to call retrieveMavenSettingsFile directly and avoid runMaven: nicer to have a single command you can copy and paste into a local shell to check build failures. Excessive Groovy functions just obscures what is actually being run.
Clone of jenkinsci/maven-hpi-plugin#156.