[JENKINS-53788] - Add profile to workaround javadoc crash on JDK 11.0.2 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batmat
added a commit
to batmat/chucknorris-plugin
that referenced
this pull request
Mar 8, 2019
oleg-nenashev
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
This is a fix for https://issues.jenkins-ci.org/browse/JENKINS-53788 . Would be nice to also ignore previous JDK versions, but profiles do not easily support it
oleg-nenashev
changed the title
|
Not sure this is the same actually, the error I'm seeing in a few places is visible on this build for instance. |
alecharp
approved these changes
Mar 8, 2019
jglick
reviewed
Mar 8, 2019
| <plugin> | ||
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <configuration> | ||
| <source>${java.level}</source> |
There was a problem hiding this comment.
I do not get it. Should this not just be the default?
diff --git a/pom.xml b/pom.xml
index 1fc3cdd..e44fcef 100644
--- a/pom.xml
+++ b/pom.xml
@@ -379,6 +379,7 @@
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.0.1</version>
<configuration>
+ <source>${java.level}</source>
<quiet>true</quiet>
<links>
<link>http://javadoc.jenkins.io/</link>There was a problem hiding this comment.
This is currently only needed, and ever was, on JDK 11.0.2. It started failing in CI recently once the JDK was bumped from 11.0.1 to 11.0.2, and this is deemed fixed in JDK 11.0.3, so I don't think it should be needed.
There was a problem hiding this comment.
The fact that builds might have worked without this is interesting but my point is that this setting should have been configured on this mojo in all cases from the start, and that this was forgotten was only discovered thanks to this bug.
There was a problem hiding this comment.
As per the evaluation by Jonathan Gibbons:
If this really is a JDK8-era program, use the javadoc option --source 8 or --release 8.
Cf. for details https://bugs.openjdk.java.net/browse/JDK-8212233 Seen among many repos these days. Known already to be blocking * jenkinsci/workflow-job-plugin#126 * jenkinsci/chucknorris-plugin#19 ...
batmat
force-pushed
the
workaround-javadoc-crash-jdk-11.0.2
branch
from
256aa39 to
4081a4d
Compare
|
Released as 3.40 |
batmat
added a commit
to batmat/buildtriggerbadge-plugin
that referenced
this pull request
Mar 21, 2019
batmat
added a commit
to batmat/workflow-support-plugin
that referenced
this pull request
Mar 27, 2019
batmat
added a commit
to batmat/aws-global-configuration-plugin
that referenced
this pull request
Mar 27, 2019
* will fix the javadoc issue, cf. jenkinsci/plugin-pom#173 * bumping to more recent powermock and mockito to be Java 11 compatible
batmat
added a commit
to batmat/cctray-xml-plugin
that referenced
this pull request
Apr 5, 2019
batmat
added a commit
to batmat/workflow-support-plugin
that referenced
this pull request
Apr 11, 2019
Picking up jenkinsci/plugin-pom#173 Also fix actual Javadoc error on JDK 11: <tt> is not allowed anymore
batmat
added a commit
to batmat/workflow-support-plugin
that referenced
this pull request
Apr 11, 2019
Picking up jenkinsci/plugin-pom#173 Also fix actual Javadoc error on JDK 11: <tt> is not allowed anymore
v1v
added a commit
to v1v/display-url-api-plugin
that referenced
this pull request
Jun 4, 2019
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. for details https://bugs.openjdk.java.net/browse/JDK-8212233
Seen among many repos these days.
Known already to be blocking
...
cc @jenkinsci/java11-support
Deployed as
3.40-20190308.114139-1. Demonstration of the fix upcoming.