Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73339] Require Java 17 and Jetty 12 (EE 9) for plugin development #1004

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

basil
Copy link
Member

@basil basil commented Sep 17, 2024

In draft until EE 9 is delivered in an LTS release.

Testing done

mvn clean verify

Fixes #936
Fixes #918

@basil basil changed the title [JENKINS-73339] Require Java 17 and Jetty 12 for plugin development [JENKINS-73339] Require Java 17 and Jetty 12 (EE 9) for plugin development Sep 17, 2024
pom.xml Outdated
<incrementals-enforce-minimum.version>1.0-beta-4</incrementals-enforce-minimum.version>
<incrementals-plugin.version>1.8</incrementals-plugin.version>
<jacoco-maven-plugin.version>0.8.12</jacoco-maven-plugin.version>
<jenkins.version>2.361</jenkins.version>
<jenkins.version>2.476</jenkins.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently using 2.476 in this PR as a placeholder, but planning to update this to whatever is selected as the next LTS line.

pom.xml Outdated
<jenkins-bom.version>${jenkins.version}</jenkins-bom.version>
<jenkins-test-harness.version>2225.2230.v6210cb_b_827f9</jenkins-test-harness.version>
<jenkins-test-harness.version>2272.v5db_817b_a_6f0d</jenkins-test-harness.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires Java 17 or newer and Jetty 12 (EE 9) or newer.

@@ -74,13 +74,13 @@
<frontend-version>1.15.0</frontend-version>
<gmavenplus-plugin.version>3.0.2</gmavenplus-plugin.version>
<hamcrest.version>3.0</hamcrest.version>
<hpi-plugin.version>3.57</hpi-plugin.version>
<hpi-plugin.version>3.58</hpi-plugin.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires Java 17 or newer and Jetty 12 (EE 9) or newer.

@basil basil force-pushed the JENKINS-73339 branch 2 times, most recently from de84494 to 6d412be Compare September 23, 2024 01:19
@basil basil marked this pull request as ready for review September 23, 2024 01:21
@basil
Copy link
Member Author

basil commented Sep 23, 2024

Moving this out of draft since 2.477 appears to be on track for LTS selection and I just performed a release of this repository. We could merge this now and then just wait about a month to release it until 2.477.1 is released. I have no strong preference, though, so if we want to wait to merge this PR, that is fine with me as well.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems useful to merge & release now, for the benefit of plugins which were obliged to switch to a 2.477 baseline for whatever reason.

@basil basil merged commit 1f6b533 into jenkinsci:master Sep 23, 2024
2 checks passed
@basil basil deleted the JENKINS-73339 branch September 23, 2024 15:16
@scherler
Copy link
Contributor

@jglick @basil yes please release, I am running into the missing new release for developing things

@jglick
Copy link
Member

jglick commented Oct 3, 2024

Thanks for release @timja!


In the long term, this ought to be mitigated by removing ASM from Jenkins core.
-->
<exclude>org.ow2.asm:asm</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causes #1032 for reasons I do not (yet) understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin POM hard-codes EE 8 Remove ASM workaround
4 participants