Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Jenkinsfile) switch WAR download to https://get.jenkins.io #363

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented May 5, 2022

Ref. jenkins-infra/helpdesk#2888

This change also uses long flags for curl and shows if an error happens during the download (easier to diagnose)

Checked locally that it keeps the same behavior:

➜ curl --silent --show-error --location https://get.jenkins.io/war-stable/2.164.1/jenkins.war --output jenkins.war
➜ echo "65543f5632ee54344f3351b34b305702df12393b3196a95c3771ddb3819b220b jenkins.war" | sha256sum --check
jenkins.war: OK
➜ date
Thu May  5 12:20:52 CEST 2022
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
    - [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ref. jenkins-infra/helpdesk#2888

This change also uses long flags for `curl` and shows if an error happens during the download (easier to diagnose)
@timja
Copy link
Member

timja commented Jul 23, 2022

@jenkinsci/plugin-compat-tester-developers could this be merged please?

@imonteroperez imonteroperez merged commit f035412 into jenkinsci:master Jul 26, 2022
@dduportal dduportal deleted the patch-1 branch July 26, 2022 16:23
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better still, use mvn dependency:get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants