Do not throw exception when Y-axis min/max properties are not set #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silent the DoubleFromString conversion exception (INFO --> FINE) It is a feature not to configure YaxisMinimum/Maximum. In that case, String values are defaulted to null. As DoubleFromString convertion is called also within hasYaxisMinimum() / hasYaxisMaximum() function (strange pattern), so convertion failure is a feature and should not raise an exception with INFO level, which is bloating Jenkins logs
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 43.38% 43.38%
Complexity 190 190
=========================================
Files 18 18
Lines 1263 1263
Branches 192 192
=========================================
Hits 548 548
Misses 651 651
Partials 64 64
Continue to review full report at Codecov.
|
vgaidarji
reviewed
Jul 11, 2020
| @@ -399,7 +399,7 @@ public Double getDoubleFromString(String input) { | |||
| try { | |||
| result = Double.parseDouble(input); | |||
| } catch (NumberFormatException nfe) { | |||
| LOGGER.log(Level.INFO, "Failed to parse Double value from String." | |||
| LOGGER.log(Level.FINE, "Failed to parse Double value from String." | |||
There was a problem hiding this comment.
@gjabouley-invn hey. have you tried actually adjusting the logic and properly verifying the input for emptiness? That was suggest in the ticket as well and looks legit.
There was a problem hiding this comment.
I've made corresponding change, it should now be aligned with your expectations
Leveraging StringUtils.IsEmty() which handles null gracefully
gjabouley-invn
changed the title
vgaidarji
added
feature
vgaidarji
changed the title
|
Thanks a lot for your contribution @gjabouley-invn. This change will be included in 2.1.8 version which was just released. 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: JENKINS-50363
Fix the GetDoubleFromString conversion exception (INFO --> FINE) when YaxisMin/Max are not set
It is a feature not to configure YaxisMinimum/Maximum. In that case, String values are defaulted to null.
As DoubleFromString convertion is called also within hasYaxisMinimum() / hasYaxisMaximum() function (strange pattern), so convertion failure is a feature and should not raise an exception with INFO level, which is bloating Jenkins logs