[JENKINS-74098] Remove inline JS script and legacy onClick handler (#147

) * remove inline JS script and legacy onClick handler * remove inline JS script and legacy onClick handler * remove inline JS script and legacy onClick handler --------- Co-authored-by: Mark Waite <[email protected]>
jenkinsci · Nov 25, 2024 · 3e73a37 · 3e73a37
1 parent efbb7f5
commit 3e73a37
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/main/resources/hudson/plugins/plot/PlotReport/index.jelly b/src/main/resources/hudson/plugins/plot/PlotReport/index.jelly
@@ -70,12 +70,8 @@
     <l:main-panel>
       <h1><l:icon class="icon-graph icon-xlg"/>${it.group}</h1>
       <div>
-        <script>
-          function jump(menu){
-            window.location.hash = menu.value;
-          }
-        </script>
-        ${%Jump to} <select name="choice" onChange="jump(this)">
+        <st:adjunct includes="hudson.plugins.plot.PlotReport.jump-to-plot" />
+        ${%Jump to} <select class="plot-selector" name="choice">
           <j:forEach var="plotJump" items="${it.plots}" varStatus="loopStat">
             <option value="#${plotJump.csvFileName}">${%Plot} ${loopStat.count}: ${plotJump.title}</option>
           </j:forEach>

diff --git a/src/main/resources/hudson/plugins/plot/PlotReport/jump-to-plot.js b/src/main/resources/hudson/plugins/plot/PlotReport/jump-to-plot.js
@@ -0,0 +1,6 @@
+document.addEventListener('DOMContentLoaded', function() {
+    const plotSelector = document.querySelector('.plot-selector');
+    plotSelector.addEventListener('change', function(e) {
+        window.location.hash = e.target.value;
+    });
+});