Forward compatibility with Commons FileUpload 2.x #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
approved these changes
May 14, 2024
| @@ -64,7 +65,7 @@ public void secretFileBaseTestWithDeprecatedCtor() throws IOException, URISyntax | |||
| } | |||
|
|
|||
| private void secretFileTest(boolean useDeprecatedConstructor) throws IOException, URISyntaxException { | |||
| DiskFileItem fileItem = createEmptyFileItem(); | |||
| FileItem fileItem = createEmptyFileItem(); | |||
There was a problem hiding this comment.
also relying on a Jenkins API rather than a particular third-party implementation will allow us to swap out the implementation in the future in jenkinsci/jenkins#9259 without breaking this test.
this is org.apache.commons.fileupload.FileItem and not a Jenkins API so this is still tied to an implementation (ie commons file upload) (albeit less of an implementation than before as this covers both v1 and v2).
There was a problem hiding this comment.
Yes exactly; your understanding is correct. I'll clarify this in detail when I write this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
hudson.model.FileParameterValue.FileItemImplis not only more consistent with other tests in the Jenkins ecosystem, but also relying on a Jenkins API rather than a particular third-party implementation will allow us to swap out the implementation in the future in jenkinsci/jenkins#9259 without breaking this test.Testing done
Works with and without jenkinsci/jenkins#9259.