Fix deprecations, avoid @Inject
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jan 16, 2024
| @Inject private transient LibraryStep step; | ||
| @StepContextParameter private transient Run<?,?> run; | ||
| @StepContextParameter private transient TaskListener listener; | ||
| private transient final LibraryStep step; |
There was a problem hiding this comment.
Somewhat oxymoronic field modifiers, but a SynchronousNonBlockingStepExecution is never usefully serialized so it makes no difference.
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| @Inject private transient ResourceStep step; | ||
| private transient final ResourceStep step; |
There was a problem hiding this comment.
Similarly, a SynchronousStepExecution should never be serialized at all.
This was referenced Jan 16, 2024
raul-arabaolaza
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup after #102.