Use new isValid() API for ParameterDefinition. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow relates to #46 but I do not follow the context. @dwnusbaum do we still want this PR? Do we need some other sort of cleanup? |
|
@dwnusbaum do you recall what this was about, and whether it is still useful? |
|
I do not remember it. It seems to be cleanup to use a new API from jenkinsci/jenkins#4826 instead of duplicating the check logic. |
jglick
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
🤷 the AbortException.message is not as nice. OTOH this could potentially handle other ParameterDefinition.isValid overrides. Seems there is still some tech debt related to #42, I guess because the API design for parameters has some fundamental flaws in terms of introspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how to use the new
ParameterDefinition.isValidmethod instead of implementing the logic locally. This is related to the new API in core from jenkinsci/jenkins#4826. See JENKINS-62889. This enhancement is expected to first appear in Jenkins 2.245 and this PR cannot be merged until that change is incorporated into all supported versions.The test failure is related to JENKINS-62889.