-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the plugin to be compatable with future versions of Guava #196
Conversation
mostly by replacing all guava occurences with non guava as it is not needed at all. However the Multimap usage remains as there is no corresponding equivallent and this API is not going to change between guava 11 and guava 31.
src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java
Show resolved
Hide resolved
src/main/java/hudson/plugins/parameterizedtrigger/CollectionUtils.java
Outdated
Show resolved
Hide resolved
List<T> list = new ArrayList<>(collection); | ||
list.addAll(Arrays.asList(ts)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
List<T> list = new ArrayList<>(collection); | |
list.addAll(Arrays.asList(ts)); | |
List<T> list = new ArrayList<>(collection.size() + ts.length); | |
list.addAll(collection); | |
list.addAll(Arrays.asList(ts)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (very nitpicking comments for test classes and not mandatory to change)
src/test/java/hudson/plugins/parameterizedtrigger/test/BuildInfoExporterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildParameterFactoryTest.java
Outdated
Show resolved
Hide resolved
@olamy I have addressed the 2 comments. Would you be able to merge and release this when the build passes? Thanks! |
mostly by replacing all guava occurences with non guava as it is not
needed at all.
However the Multimap usage remains as there is no corresponding
equivallent and this API is not going to change between guava 11 and
guava 31.
for details see https://groups.google.com/g/jenkinsci-dev/c/aYUJ4VuOuVc/m/I9IEEzovAgAJ
@olamy