Merge pull request #278 from jmMeessen/suppress-spotbug-warnings

Suppress spotbugs errors

pom.xml

@@ -230,5 +230,6 @@
     <java.level>8</java.level>
     <jenkins.version>2.332.1</jenkins.version>
     <spotbugs.failOnError>false</spotbugs.failOnError>
+    <spotbugs.excludeFilterFile>suppressed-spotbug-errors.xml</spotbugs.excludeFilterFile>
   </properties>
 </project>

suppressed-spotbug-errors.xml

@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- 
+    see https://spotbugs.readthedocs.io/en/stable/filter.html#source
+    and https://stackoverflow.com/questions/52336795/spotbugs-maven-plugin-exclude-a-directory
+    for an explanation of the technique
+ -->
+<FindBugsFilter>
+    <!-- <Match>
+        <Source name="~.*BlockableBuildTriggerConfig\.java"/>
+    </Match> -->
+    <Match>
+    <Or>
+        <And>
+            <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
+            <Class name="hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig"/>
+        </And>
+        <And>
+            <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/>
+            <Class name="hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig"/>
+        </And>
+        <And>
+            <Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS"/>
+            <Class name="hudson.plugins.parameterizedtrigger.Plugin"/>
+      </And>
+        <And>
+            <Bug pattern="UUF_UNUSED_FIELD"/>
+            <Class name="hudson.plugins.parameterizedtrigger.FileBuildTriggerConfig"/>
+      </And>
+        <And>
+            <Bug pattern="UUF_UNUSED_FIELD"/>
+            <Class name="hudson.plugins.parameterizedtrigger.PredefinedPropertiesBuildTriggerConfig"/>
+      </And>
+        <And>
+            <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
+            <Class name="hudson.plugins.parameterizedtrigger.NodeParameters"/>
+      </And>
+    </Or>
+  </Match>
+</FindBugsFilter>