Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Powershell script to update registry information after war update #494

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slide
Copy link
Member

@slide slide commented Dec 4, 2024

Adds a script to the Windows installer that can be used to update the registry information from the new war file after it is upgraded using the Jenkins UI. The script is signed using signtool which allows creating a function for the signing and calling it for the ps1 and the msi file(s) that are generated. Since the signing information is added to the ps1, it is first copied into tmp to avoid changing a version controlled file.

Supersedes #492

Testing done

I ran the signing enabled flow with a self signed certificate and was able to sign both the ps1 and msi.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

slide added 2 commits December 2, 2024 20:40
Adds a script to the installer which will update the version
information in the registry for Jenkins after an upgrade of
the WAR file vie the Jenkins UI.
Switches to use signtool to sign the ps1 script. This allowed
moving the signing into a function and reusing it in two places.
@slide slide requested a review from a team as a code owner December 4, 2024 01:21
@slide
Copy link
Member Author

slide commented Dec 4, 2024

I need to look at adding the msi build to the Jenkinsfile so we can catch things like the previous implementation before they get merged.

@timja
Copy link
Member

timja commented Dec 4, 2024

I need to look at adding the msi build to the Jenkinsfile so we can catch things like the previous implementation before they get merged.

Did you want to do this before merging of this?

@slide
Copy link
Member Author

slide commented Dec 4, 2024

Let me scope it out at least

@slide
Copy link
Member Author

slide commented Dec 6, 2024

My scoping of the work to add the MSI build to the Jenkinsfile showed that it might be better to go to a newer version of Wix before trying that. Is there a way we can run a test release flow with this PR to make sure it won't break it?

@timja
Copy link
Member

timja commented Dec 7, 2024

My scoping of the work to add the MSI build to the Jenkinsfile showed that it might be better to go to a newer version of Wix before trying that. Is there a way we can run a test release flow with this PR to make sure it won't break it?

I wonder if the easiest way would be to change it to the VM agent and then prepare it as part of adding CI to this repo?

ref jenkins-infra/helpdesk#2745 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants