-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Jenkinsfile) inherit pod definition from existing pod template #465
Conversation
I've given you access, not sure if you'll have to create a new PR or not (or just replay) |
OK, I'm definitievely missing something with the Kubernetes plugin:
=> Let's assume we want packaging to have it own pod template provided by jenkins-infra team |
I got the following problem: if I use the
However, if I use Groovy form, then the merge is performed as expected, which makes me say it's not because of the parent pod template setup (default to cc @Vlatombe @jglick @timja if it rings a bell (I bet it's something I don't understand in the inheritance system). => As such, I'll stick to the groovy method for now, as a tradeoff between developer autonomy (this repository needs advanced tooling such as ansible which might require tuning the pod template) and "admin defined setup). |
@timja @basil @MarkEWaite , this PR is ready to roll: it spins up a pod with succes from the Please note that the tests errors are during the "Test" stage, and happens in a VM (Docker) agent. I leave you to it if you want to merge this PR despite the checks errors, or if you want to fix the Tests first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related to jenkins-infra/helpdesk#4106, this PR is a try to have an inherited pod template definition for the build agent on ci.jenkins.io.
The goal is to ensure that administrator-defined settings such as tolerations can be reused without having to maintain a full-fledged pod YAML.
I had difficulties to have the inheritance working with a YAML inline (of from file) so I chose t override the image in pure Groovy: the merge never happened which looks weird to me: either I got the inherited image or the local yaml but never the merge (tried implicit merge, or setting up all yaml merge strategies). I most probably missed something: another pair of eye would help.
Partial success as we have the expected image and environment variables, along with inherited pod. The agent starts but the test phase of the pipeline fails which might be related to the not-transplanted elements: