-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packaging support for unix domain sockets #442
Conversation
- Add /run/jenkins path in systemd-tmpfiles as a home for the socket - Support JENKINS_UNIX_DOMAIN_PATH variable to pass the socket path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cc @kmartens27 / @MarkEWaite for changelog |
@@ -0,0 +1 @@ | |||
D /run/jenkins 0770 jenkins jenkins - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RuntimeDirectory="jenkins"
in jenkins.service
should be a better fit here than a tmpfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in
jenkins.service
should be a better fit here than a tmpfile.
It is usually much more effective to submit a pull request with an explanation why a different location would be better. If you're not ready to submit a pull request, then an issue report is another way to start the conversation.
Commenting on a merged pull request is not nearly as likely to result in any action.
Added to winstone: jenkinsci/winstone#346 / jenkinsci/winstone#345
Testing done
jenkins.war from most recent master
RPM created as follows:
Apache httpd configured as follows:
Submitter checklist