Add kotlin-reflect to dependencies

[sghill]

Hi folks! What do you think about adding kotlin-reflect as a dependency?

I have a custom plugin that needs jackson-module-kotlin, which in turn requires kotlin-reflect. Today I can build up this dependency tree below, but unfortunately I get a kotlin.jvm.KotlinReflectionNotSupportedError: Kotlin reflection implementation is not found at runtime. Make sure you have kotlin-reflect.jar in the classpath

+ my plugin
     + jackson2-api
     + jackson-module-kotlin
     + okhttp-api
     + kotlin-reflect

By adding kotlin-reflect to okhttp-api, the exception goes away. The dependency tree now looks like:

+ my plugin
     + jackson2-api
     + jackson-module-kotlin
     + okhttp-api
         + kotlin-reflect

This works great for me and I think is a practical solution, but I can also see how it may be better to split off a kotlin-api plugin instead. Happy to do that if it's preferred. For what it's worth, my only uses for kotlin involve okhttp and jackson.

Testing done

Published my version and ran with it locally, proving the runtime exception no longer happens.
Existing tests pass.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jtnord]

This works great for me and I think is a practical solution, but I can also see how it may be better to split off a kotlin-api plugin instead. Happy to do that if it's preferred. For what it's worth, my only uses for kotlin involve okhttp and jackson.

as there are now a few plugins using kotlin I would think a new modular set of API plugins containing the kotlin runtime / extras should be introduced (similar to the AWS SDK) so that this and other plugins can depend on them.

Obviously this would not work if kotlin introduces breaking changes - but it strives to maintain backwards compatibility but also says it can break things, so this may not be a good option?