Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move documentation from wiki to github #39

Merged
merged 3 commits into from
Feb 26, 2021
Merged

move documentation from wiki to github #39

merged 3 commits into from
Feb 26, 2021

Conversation

KasperHeyndrickx
Copy link
Contributor

No description provided.

@jetersen
Copy link
Member

jetersen commented Dec 2, 2019

link to see current commit author: https://github.com/jenkinsci/msbuild-plugin/commit/a7a4862f2feee787a4fd4a28f830ba6e332e0277.patch

@KasperHeyndrickx
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

@KasperHeyndrickx
Copy link
Contributor Author

@marshall777 Could you take a look at these changes?
This moves documentation from wiki to git. https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/

jetersen
jetersen approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jetersen
jetersen reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 14 to 15
"C:\\Program Files (x86)\\Microsoft Visual
Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\" If you have multiple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you're suggesting here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to suggest #39 (comment) 😅

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jetersen
jetersen reviewed Dec 3, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@KasperHeyndrickx @jetersen
Update README.md
0e4a52f 
Co-Authored-By: Joseph Petersen <[email protected]>
oleg-nenashev
oleg-nenashev approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MRamonLeon MRamonLeon merged commit c9bd114 into jenkinsci:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Plugin documentation Migration (Wiki=>GitHub)
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KasperHeyndrickx @jetersen @oleg-nenashev @MRamonLeon