Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin is not being installed by default starting from Jenkins 2 #99

Merged
merged 2 commits into from
Jul 4, 2017

Conversation

oleg-nenashev
Copy link
Member

The text appears in the Plugin manager, and it may be misleading

@reviewbybees @aheritier

The text appears in the Plugin manager, and it may be misleading
@ghost
Copy link

ghost commented May 24, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@aheritier aheritier closed this May 24, 2017
@aheritier aheritier reopened this May 24, 2017
@aheritier
Copy link
Member

Crappy test. Not related to the PR. 🐝 for the PR

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is worth adding a sentence to the description giving users a taste of what “deep integration” can imply, for better and for worse?

@jglick
Copy link
Member

jglick commented May 24, 2017

(And at this point I think no one cares that it used to be a part of Jenkins core. Ancient history.)

@aheritier
Copy link
Member

WDYT of the update I did @jglick @oleg-nenashev @olamy ?

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check test failure—I think random?

@aheritier
Copy link
Member

yes random test failure :( @jglick

@oleg-nenashev
Copy link
Member Author

(And at this point I think no one cares that it used to be a part of Jenkins core. Ancient history.)

I have thought about it, but decided to remove only the 100% wrong part. Polish needs massive polishing anyway

@aheritier aheritier merged commit 960c01e into master Jul 4, 2017
@aheritier aheritier deleted the pom-xml-patch branch July 4, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants