-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven plugin is not being installed by default starting from Jenkins 2 #99
Conversation
The text appears in the Plugin manager, and it may be misleading
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Crappy test. Not related to the PR. 🐝 for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is worth adding a sentence to the description giving users a taste of what “deep integration” can imply, for better and for worse?
(And at this point I think no one cares that it used to be a part of Jenkins core. Ancient history.) |
WDYT of the update I did @jglick @oleg-nenashev @olamy ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check test failure—I think random?
yes random test failure :( @jglick |
I have thought about it, but decided to remove only the 100% wrong part. Polish needs massive polishing anyway |
The text appears in the Plugin manager, and it may be misleading
@reviewbybees @aheritier