Adapt to Jakarta Activation and Jakarta Mail upgrades #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
dependencies
basil
changed the title
basil
commented
Mar 4, 2024
Comment on lines
+775
to
+779
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>jakarta-mail-api</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Moving this above the mock-javamail dependency for a few reasons:
- It comes first in group ID order, which is how Spotless would sort it.
- There was previously a requirement that
mock-javamailcome first, but that is no longer needed after implementing the system properties described in docs: clarify usage for tests with jvm system properties lib-mock-javamail#53.
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>jakarta-activation-api</artifactId> | ||
| <version>2.1.3-1</version> |
There was a problem hiding this comment.
First version with the new Jakarta packages.
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>jakarta-mail-api</artifactId> | ||
| <version>2.1.3-1</version> |
There was a problem hiding this comment.
First version with the new Jakarta packages.
| <dependency> | ||
| <groupId>org.jvnet.mock-javamail</groupId> | ||
| <artifactId>mock-javamail</artifactId> | ||
| <version>2.1</version> | ||
| <version>2.2</version> |
There was a problem hiding this comment.
First version with the new Jakarta packages.
Comment on lines
+856
to
+858
| <mail.smtp.class>org.jvnet.mock_javamail.MockTransport</mail.smtp.class> | ||
| <mail.pop3.class>org.jvnet.mock_javamail.MockStore</mail.pop3.class> | ||
| <mail.imap.class>org.jvnet.mock_javamail.MockStore</mail.imap.class> |
There was a problem hiding this comment.
Deterministic use of Mock Javamail rather than relying on it being first in the classpath (!).
MarkEWaite
approved these changes
May 20, 2024
basil
added
internal
and removed
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts to recent releases of Jakarta Activation and Jakarta Mail, which use new Maven coordinates.
Testing done
CI build is green: https://ci.jenkins.io/job/Plugins/job/maven-plugin/job/PR-321/3/