Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-49089] Whitelist problems #112

Merged
merged 4 commits into from
Jan 24, 2018
Merged

[JENKINS-49089] Whitelist problems #112

merged 4 commits into from
Jan 24, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 23, 2018 •
edited
Loading

JENKINS-49089

  • at least get some tests running
  • find a way to make this code path be run in a test before saveing the build
  • make some ModuleDependency fields transient

@reviewbybees

jglick
jglick commented Jan 23, 2018
View reviewed changes
src/main/java/hudson/maven/SplittableBuildListener.java
@@ -53,7 +53,7 @@
* @author Kohsuke Kawaguchi
* @since 1.133
*/
final class SplittableBuildListener extends AbstractTaskListener implements BuildListener, Serializable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/jenkins#3154 (comment) grr

@jglick
Deleting ModuleDependencyLocator as it was an extension point defined…
2556bcc 
… by accident in test sources and so of course never used!

Cf. e68ef92 by @kohsuke:
“Checking in my partial work on this issue.”
@jglick
No particular need to test against LTS if we are already testing agai…
a52c069 
…nst something newer.
@jglick
Copy link
Member Author

jglick commented Jan 23, 2018

Bug introduced by jenkinsci/jenkins@e418e44 with the helpful commit message by @kohsuke

Massaging the pull request to simplify the code.

It seems to have been from jenkinsci/jenkins#542.

@jglick
Copy link
Member Author

jglick commented Jan 23, 2018

…which did add test coverage—but using mocks. Making it useless for actually detecting regressions like this.

@jglick
Copy link
Member Author

jglick commented Jan 23, 2018 •
edited
Loading

…and the test has to be Ignored on newer cores anyway (as of #109), again due to use of mocks.

@jglick
Copy link
Member Author

jglick commented Jan 23, 2018

I tried to follow what the code here is doing, in an effort to craft a functional test which would trigger this code path, but could not do so after brief effort. I am not inclined to waste too much time working on this plugin; probably better to release a fix based on code inspection & reasoning, and hope it suffices.

oleg-nenashev
oleg-nenashev approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 It should not make it worse at least

@jglick
Copy link
Member Author

jglick commented Jan 23, 2018

@reviewbybees done but not sure who normally releases this—@oleg-nenashev? @aheritier?

@oleg-nenashev
Copy link
Member

I have reached out to @aheritier to sync-up on that

@oleg-nenashev oleg-nenashev merged commit ab7e259 into jenkinsci:master Jan 24, 2018
@jglick jglick deleted the JEP-200-JENKINS-49089 branch January 25, 2018 15:18
@jglick jglick mentioned this pull request Mar 19, 2018
Merged
@jglick jglick mentioned this pull request Jan 27, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @oleg-nenashev