Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dependencies of Maven Plugins are expected to be in provided scope #311

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 22, 2022

Fixes the following build warning by placing the dependencies in the <provided> scope:

[ERROR] 

Some dependencies of Maven Plugins are expected to be in provided scope.
Please make sure that dependencies listed below declared in POM
have set '<scope>provided</scope>' as well.

The following dependencies are in wrong scope:
 * org.apache.maven:maven-model:jar:3.8.5:compile
 * org.apache.maven:maven-core:jar:3.8.5:compile
 * org.apache.maven:maven-settings:jar:3.8.5:compile
 * org.apache.maven:maven-settings-builder:jar:3.8.5:compile
 * org.apache.maven:maven-builder-support:jar:3.8.5:compile
 * org.apache.maven:maven-repository-metadata:jar:3.8.5:compile
 * org.apache.maven:maven-model-builder:jar:3.8.5:compile
 * org.apache.maven:maven-resolver-provider:jar:3.8.5:compile
 * org.apache.maven:maven-artifact:jar:3.8.5:compile
 * org.apache.maven:maven-plugin-api:jar:3.8.5:compile

@basil basil requested review from jglick and Vlatombe March 22, 2022 14:10
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a technical reason for the dependencies to be moved later in the POM (so having a larger diff) or just stylistic (grouping by scope)?

@basil
Copy link
Member Author

basil commented Mar 22, 2022

Is there a technical reason for the dependencies to be moved later in the POM (so having a larger diff) or just stylistic (grouping by scope)?

The latter.

@basil basil merged commit 39bd76b into jenkinsci:master Mar 22, 2022
@basil basil deleted the pom branch March 22, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants