Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure implementation and specification entries are present in MANIFEST.MF #251

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

basil
Copy link
Member

@basil basil commented Nov 26, 2021

Fixes an (unreleased) regression introduced in #247.

@basil basil added the bug label Nov 26, 2021
@basil basil merged commit 8611238 into jenkinsci:master Nov 26, 2021
@basil basil deleted the manifest branch November 26, 2021 20:33
@Vlatombe
Copy link
Member

Vlatombe commented Jan 14, 2022

@basil This makes plugin packaging fail badly (cryptic Caused by: java.io.IOException: invalid header field) if the maven project>description contains a newline character. By the way, shouldn't Specification-Title be project.getName() instead?

@basil
Copy link
Member Author

basil commented Jan 14, 2022

Sorry, I somehow clicked edit rather than reply. Here is my reply:

@basil This makes plugin packaging fail badly (cryptic Caused by: java.io.IOException: invalid header field) if the maven project>description contains a newline character.

Thanks for the notification. Was this an informational notification, or are you implying that I should take some sort of action as a result of this notification?

By the way, shouldn't Specification-Title be project.getName() instead?

You tell me. Should it? Shouldn't it? Why? Why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants