Reimplement the UI for LabelAxis
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LabelAxis configuration was using yahoo treeview. As yahoo is very old and deprecated we should remove this. The will generate the complete configure page in jelly and just add some small javascript to show/hide the lists with labels.
show the description as tooltip instead of adding it in brackets after the label name. The description can contain html so we need to safe guard it with the markupformatter.
|
I would be OK with merging/releasing this once conflicts are resolved and passing ATH/PCT runs are done |
|
ATH fails with this change, but the fix is easy, see jenkinsci/acceptance-test-harness#1762 |
basil
changed the title
LabelAxis
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LabelAxis configuration was using yahoo treeview. As yahoo is very old and deprecated we should remove this.
Generate the complete configure page in jelly and just add some small javascript to show/hide the lists with labels.
The label description is no longer printed in brackets after the label name but instead shown as a html tooltip. The MarkupFormatter is used to generate the html so it should be safe and it is displayed in the same way as on the label page.
Once merged requires changes to ATH
Before:
After:
Testing done
Manually tested, that after saving all axis are properly defined
Submitter checklist