Upgrade metadata #7
Conversation
| @@ -2,9 +2,10 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
|
|
|||
| <parent> | |||
| <groupId>org.sonatype.oss</groupId> | |||
| <artifactId>oss-parent</artifactId> | |||
There was a problem hiding this comment.
deprecated: https://github.com/sonatype/oss-parents
pom.xml
Outdated
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <sonatypeOssDistMgmtSnapshotsUrl>https://oss.sonatype.org/content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl> |
There was a problem hiding this comment.
I basically inlined most of what was in the last oss-parent release
There was a problem hiding this comment.
Well if we are going to use the Jenkins parent then delete this.
| <groupId>org.jenkins-ci</groupId> | ||
| <artifactId>jenkins</artifactId> | ||
| <version>1.62</version> | ||
| <relativePath /> |
There was a problem hiding this comment.
This will cease to publish to OSSRH and thus to Central. Probably OK for our purposes? I am not exactly sure what this plugin is for. If it is to appear in a plugin POM, then using our Artifactory only would be OK, since pluginRepositories should be defined.
There was a problem hiding this comment.
It's the thing that extracts licenses from dependencies to show on Jenkins about page: http://localhost:8080/jenkins/about/
it allows running groovy to filter licenses / choose one etc:
https://github.com/jenkinsci/jenkins/blob/e7ca5dbc4473206b7e90f8ea612493a04c57817c/war/pom.xml#L441
https://github.com/jenkinsci/jenkins/blob/master/licenseCompleter.groovy
There was a problem hiding this comment.
This will cease to publish to OSSRH and thus to Central
yeah sounds fine
| @@ -13,17 +14,20 @@ | |||
| <packaging>maven-plugin</packaging> | |||
|
|
|||
| <name>maven-license-plugin Maven Plugin</name> | |||
| <url>http://maven.apache.org</url> | |||
| <url>https://maven.apache.org</url> | |||
There was a problem hiding this comment.
well one step better than before =/ this plugin has no docs
pom.xml
Outdated
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <sonatypeOssDistMgmtSnapshotsUrl>https://oss.sonatype.org/content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl> |
There was a problem hiding this comment.
Well if we are going to use the Jenkins parent then delete this.
| <repositories> | ||
| <repository> | ||
| <id>sonatype-nexus-snapshots</id> | ||
| <name>Sonatype Nexus Snapshots</name> |
| @@ -104,7 +104,6 @@ public void accept(String name) { | |||
| return; | |||
| } | |||
| } | |||
| IllegalStateException error = new IllegalStateException("Expecting " + name + " but found " + toString(licenses) + " for dependency " + toString(dependency)); | |||
There was a problem hiding this comment.
it didn't do anything, spotbugs marked this as a 'high' bug
| comp.add((LicenseScript) shell.parse(getClass().getResourceAsStream("xmlgen.groovy"),"xmlgen.groovy")); | ||
| if (generateLicenseXml!=null) { | ||
| try { | ||
| comp.add((LicenseScript) shell.parse(getClass().getResource("xmlgen.groovy").toURI())); |
There was a problem hiding this comment.
Is using getResource the fix here?
There was a problem hiding this comment.
the method parameters changed, InputStream isn't valid anymore, I chose the URI method
Not sure. Where did you come across this plugin? |
Jenkins core, every time I compile I get multiple IllegalReflectiveAccess warnings because of this plugin -.- |
|
So should I just remove all sonatype and publish to Jenkins artifactory? |
|
Seems to be used mainly from https://github.com/jenkinsci/pom/blob/b39188baf69a4c4a2d8dadfee2281ddedd9190b5/pom.xml#L593-L597 + https://github.com/jenkinsci/plugin-pom/blob/655257b6dc9a14b44e096ed5af8d142711068069/pom.xml#L418-L422. The risk is that someone outside the Jenkins org was using it, in which case they will cease to see updates if we switch to Artifactory. I am inclined to try to get it transferred to @jenkinsci though I am not sure who owns it (I have write access only). Seems to be Apache-licensed though it is unclear. Will ask around. |
Did you get anywhere @jglick? |
|
Not really. Can you split out the actual Groovy update into a minimal PR I can release safely? |
|
Will try do something less invasive, think the Pom needed updates for the new groovy version or maven on my machine |
|
Mm, OK. Would just prefer something I can continue to release to OSSRH. Typically we use https://github.com/kohsuke/pom for that; not sure why this one is using |
|
Because it’s ancient 😂 |
see https://docs.google.com/document/d/1GRwJCfybnW8X273cPhOc2q4kdpqocX2zm_857DBGCY8 |
cc @jglick @oleg-nenashev
also is there a reason this is in Cloudbees org? seems very specific to Jenkins
Tested with Jenkins core, all seems the same except some minor whitespace difference in XML, and displayed in core all looks fine