Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groovy-xml for Java 21 compatibility #15

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jun 17, 2023

I was investigating into the prerequisites of compiling Jenkins core with Java 21, and noticed, bumping groovy-xml does the trick already for this maven plugin.

Could we get a release of this, once merged @jglick?

@NotMyFault NotMyFault changed the title Update dependencies for Java 21 compatibility Update groovy-xml for Java 21 compatibility Jun 17, 2023
@jglick
Copy link
Member

jglick commented Jun 28, 2023

Would be great to transfer this to @jenkinsci, though releasing to Central is perhaps the bigger issue.

@jglick jglick merged commit f33f496 into jenkinsci:master Jun 28, 2023
@jglick
Copy link
Member

jglick commented Jun 28, 2023

https://github.com/cloudbees/maven-license-plugin/releases/tag/maven-license-plugin-1.16 should be on Central shortly.

@NotMyFault NotMyFault deleted the jdk-21 branch June 28, 2023 18:41
@NotMyFault
Copy link
Member Author

Would be great to transfer this to @jenkinsci, though releasing to Central is perhaps the bigger issue.

To be fair, I'd rank this plugin at the same level of needs of releases as archetypes, maybe even lower, cutting releases when needed.

Given it's an inherent part of the plugin and parent pom, I favor the transfer to the jenkinsci org, if that's fine with CloudBees.

@jglick
Copy link
Member

jglick commented Jun 28, 2023

Fine from my perspective. I lack Admin permission here (and anything at the @jenkinsci org level) so it would take some permission wrangling, and then IIRC there would need to be an OSSRH ticket to grant release access to a selection of people (no idea who else has it now).

@NotMyFault
Copy link
Member Author

I can take care of approving the transfer from the jenkinsci org, just shoot me a ping.
Everything else is out of my hand.

@jglick
Copy link
Member

jglick commented Jun 28, 2023

Ack. Internal reference: OPS-17026

@NotMyFault
Copy link
Member Author

jenkinsci/maven-license-plugin has been deleted

@NotMyFault
Copy link
Member Author

In case transferring to jenkinsci does not work due to the org configuration, you may transfer it to https://github.com/jenkinsci-transfer, from where I can transfer it to jenkinsci.

@jglick
Copy link
Member

jglick commented Jun 30, 2023

@NotMyFault I have no permission to transfer anything anywhere. If you want to add someone to that org, add @tgill2.

@tgill2
Copy link

tgill2 commented Jun 30, 2023

@NotMyFault , I am getting error :

You don’t have the permission to create public repositories on jenkinsci-transfer

Could you please add permissions for me or add me to a team maybe?

@NotMyFault
Copy link
Member Author

NotMyFault commented Jun 30, 2023

@NotMyFault , I am getting error :

You don’t have the permission to create public repositories on jenkinsci-transfer

Could you please add permissions for me or add me to a team maybe?

I've sent you an invitation to the https://github.com/jenkinsci-transfer organization

@tgill2
Copy link

tgill2 commented Jul 4, 2023

Transferred repository to jenkinsci-transfer.

@NotMyFault
Copy link
Member Author

Transferred repository to jenkinsci-transfer.

Thanks so much! I transferred the repository to the jenkinsci organization.


@jglick

and then IIRC there would need to be an OSSRH ticket to grant release access to a selection of people (no idea who else has it now)

Given the groupId is com.cloudbees and OSSRH perms are scoped to groupIds, the people who could've been given release permissions appear to be limited to CloudBees employees.

I did a little search, and it appears, the plugin is almost nowhere used outside the Jenkins project scope (ignoring non-forks of Jenkins, hudson, security testing, etc.).
We could cease publishing to the central repository and publish releases to repo.jenkins-ci.org.
This way, we can automate releases via CD or grant a broader audience (not every jenkinsci/core member is a CloudBees employee) permissions to cut releases.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants