Merge pull request #32 from jglick/majorVersion

Documenting counterintuitive behavior of `DefaultArtifactVersion.majorVersion` with `.` separator
jenkinsci · Jan 13, 2022 · 4e30093 · 4e30093
2 parents f1ed0e9 + db7d2a1
commit 4e30093
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/test/java/hudson/util/VersionNumberTest.java b/src/test/java/hudson/util/VersionNumberTest.java
@@ -27,6 +27,7 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.apache.maven.artifact.versioning.ComparableVersion;
+import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
 import org.hamcrest.CoreMatchers;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ -138,6 +139,17 @@ public void backportJep229() {
         assertOrderAlsoInMaven("99.v1234deadbeef", "99.5.vabcd1234abcd", "99.10.vabcd1234abcd", "100.vdead9876beef");
     }
 
+    @Issue("https://github.com/jenkinsci/incrementals-tools/issues/29")
+    @Test
+    public void majorVersion() {
+        assertOrderAlsoInMaven("1.1", "391.ve4a_38c1b_cf4b_");
+        // Weird but TBD if this matters in practice:
+        assertEquals(0, new DefaultArtifactVersion("391.ve4a_38c1b_cf4b_").getMajorVersion());
+        // More natural behavior of majorVersion:
+        assertOrderAlsoInMaven("1.1", "200.vabcd1234abcd", "391-ve4a_38c1b_cf4b_");
+        assertEquals(391, new DefaultArtifactVersion("391-ve4a_38c1b_cf4b_").getMajorVersion());
+    }
+
     @Test
     public void testOrEqualTo() {
         assertTrue(new VersionNumber("1.8").isNewerThanOrEqualTo(new VersionNumber("1.8")));