Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support files opened via Files#newBufferedWriter #161

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

adangel
Copy link
Contributor

@adangel adangel commented Oct 18, 2023

I noticed, that files opened via Files.newBufferedWriter were not tracked.
This is added now - using sun.nio.ch.FileChannelImpl - the close of the file was already recognized, as internally the file is handled as a FileChannel.

Testing done

Test added in FileDemo. Also added a test for Files.newBufferedReader - but that already worked.

Locally tested with java 11, 17, 21 (mvn clean integration-test)

Submitter checklist

Preview Give feedback

@basil basil changed the title Support Files.newBufferedWriter Support files opened via Files#newBufferedWriter Feb 29, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 91e3597 into jenkinsci:master Feb 29, 2024
13 checks passed
@adangel adangel deleted the files-newbufferedwriter branch March 1, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants