-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-66247] Call Index.listClassNames
#52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2021
…fier into listClassNames-JENKINS-66247
Marking as draft since I am not sure when it will be safe to merge this (without blocking unrelated changes from being released). |
…fier into listClassNames-JENKINS-66247
Can this be moved out of draft now that the build toolchain requires 2.361 or newer? |
So jenkinsci/lib-annotation-indexer#12 went into 1.15 integrated via jenkinsci/jenkins#5639 in 2.305 ✔️ |
…fier into listClassNames-JENKINS-66247
timja
approved these changes
Dec 1, 2022
basil
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/lib-annotation-indexer#12. Amends #50. Unfortunately we cannot use this in
plugin-pom
any time soon because the version ofaccess-modifier-checker
must remain somehow compatible (not throw exceptions) when working with an older version ofannotation-indexer
present in core. Thus we cannot upgrade the checker until the minimum core version (some LTS) includes the dependency bump.