Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set maven libs according to consumers #144

Merged
merged 2 commits into from
Mar 7, 2023
Merged

set maven libs according to consumers #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a395c19
set maven libs according to consumers
jtnord Mar 6, 2023
f21402a
ignore slf4j from upper-bounds
jtnord Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ updates:
directory: "/"
schedule:
interval: "weekly"
ignore:
# maven core artifacts are provided by the running maven, do not update to prevent consuming something unavailable
- dependency-name: "org.apache.maven:*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
8 changes: 6 additions & 2 deletions access-modifier-checker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@
<name>Custom Access Modifier Checker</name>

<properties>
<maven.version>3.9.0</maven.version>
<maven.version>3.8.1</maven.version>
</properties>

<prerequisites>
<maven>${maven.version}</maven>
</prerequisites>

<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
Expand Down Expand Up @@ -74,7 +78,7 @@
<rules>
<requireUpperBoundDeps>
<excludes combine.children="append">
<exclude>org.apache.commons:commons-lang3</exclude>
<exclude>org.slf4j:slf4j-api</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[ERROR] Require upper bound dependencies error for org.slf4j:slf4j-api:1.7.29 [provided] paths to dependency are:
[ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT
[ERROR]   +-org.apache.maven:maven-core:3.8.1 [provided]
[ERROR]     +-org.apache.maven:maven-resolver-provider:3.8.1 [provided]
[ERROR]       +-org.slf4j:slf4j-api:1.7.29 [provided]
[ERROR] and
[ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT
[ERROR]   +-org.apache.maven:maven-core:3.8.1 [provided]
[ERROR]     +-org.apache.maven.resolver:maven-resolver-impl:1.6.2 [provided]
[ERROR]       +-org.slf4j:slf4j-api:1.7.30 [provided]```

maven 3.8.1 ships with slf4j-api 1.7.29 so the fact its resolver requires a newer slf4j is just daft.

for now (as this is an old version of maven) just ignore slf4j.

Removes org.apache.commons:commons-lang as that is not a collision

</excludes>
</requireUpperBoundDeps>
</rules>
Expand Down